Fix action menu modals rendering inside dropdown containers

[abdulrahmancodes]

Closes #16363

• Updated modals to open in the full screen by default

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[sentry]

Bug: The modal backdrop incorrectly receives position: absolute instead of position: fixed for full-screen modals because isInContainer is miscalculated when effectiveContainer defaults to document.body.
_{Severity: HIGH | Confidence: High}

🔍 Detailed Analysis

The change to default ignoreContainer to true and set effectiveContainer to document.body introduces a logical bug. The variable isInContainer is now always true for full-screen modals, as it checks isDefined(effectiveContainer). This incorrectly applies position: absolute to the modal backdrop instead of the intended position: fixed. Consequently, the backdrop may not cover the entire viewport when the page is scrolled and can lead to z-index and layering issues, contradicting the goal of making modals full-screen by default.

💡 Suggested Fix

The calculation for isInContainer should be updated. It should not be based on whether effectiveContainer is defined. Instead, it should reflect whether the modal is meant to be constrained within a specific parent element, which is the case when the container prop is passed and ignoreContainer is false.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
packages/twenty-front/src/modules/ui/layout/modal/components/Modal.tsx#L233-L236

Potential issue: The change to default `ignoreContainer` to `true` and set
`effectiveContainer` to `document.body` introduces a logical bug. The variable
`isInContainer` is now always `true` for full-screen modals, as it checks
`isDefined(effectiveContainer)`. This incorrectly applies `position: absolute` to the
modal backdrop instead of the intended `position: fixed`. Consequently, the backdrop may
not cover the entire viewport when the page is scrolled and can lead to z-index and
layering issues, contradicting the goal of making modals full-screen by default.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6894383}

[cubic-dev-ai]

No issues found across 1 file

[twenty-eng-sync]

Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[github-actions]

Thanks @abdulrahmancodes for your contribution!
This marks your 96th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter