[Dashboards] Rich text editor frontend by ehconitin · Pull Request #16437 · twentyhq/twenty

ehconitin · 2025-12-09T16:22:01Z

closes twentyhq/core-team-issues#1894

…ontend

This reverts commit 332f7db.

…ontend

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

github-actions · 2025-12-09T16:23:04Z

TODOs/FIXMEs:

~~// TODO: Remove this once we have removed the old rich text~~: packages/twenty-front/src/modules/activities/components/ActivityRichTextEditor.tsx
// TODO: when we have more widgets without headers, we should use a more generic approach to hide the header: packages/twenty-front/src/modules/page-layout/widgets/components/WidgetRenderer.tsx

Generated by 🚫 dangerJS against 9807c52

cubic-dev-ai

2 issues found across 17 files

Prompt for AI agents (all 2 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/page-layout/hooks/useCreatePageLayoutStandaloneRichTextWidget.ts">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/hooks/useCreatePageLayoutStandaloneRichTextWidget.ts:65">
P2: Error message references &quot;iframe widget&quot; but this hook creates a standalone rich text widget. This appears to be a copy-paste error that will confuse developers debugging issues.</violation>
</file>

<file name="packages/twenty-front/src/modules/ui/input/editor/utils/parseInitialBlocknote.ts">

<violation number="1" location="packages/twenty-front/src/modules/ui/input/editor/utils/parseInitialBlocknote.ts:18">
P1: Type safety issue: `JSON.parse` can return any type, but only empty arrays are filtered out. If the parsed JSON is not an array (e.g., an object, string, or number), it will be returned despite the `PartialBlock[] | undefined` return type. The condition should validate that the result is actually an array before returning.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

...es/twenty-front/src/modules/page-layout/hooks/useCreatePageLayoutStandaloneRichTextWidget.ts

packages/twenty-front/src/modules/ui/input/editor/utils/parseInitialBlocknote.ts

…ontend

…cknote editor for dashbaords

…ontend

cubic-dev-ai · 2025-12-12T11:20:45Z

@cubic-dev-ai review trigger

@ehconitin I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

2 issues found across 38 files

Prompt for AI agents (all 2 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/page-layout/widgets/components/WidgetRenderer.tsx">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/components/WidgetRenderer.tsx:64">
P3: Typo in comment: &quot;wihtout&quot; should be &quot;without&quot;.</violation>
</file>

<file name="packages/twenty-front/src/modules/page-layout/widgets/standalone-rich-text/components/DashboardBlockDragHandleMenu.tsx">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/standalone-rich-text/components/DashboardBlockDragHandleMenu.tsx:83">
P1: Inconsistent editor usage: The function mixes `blockNoteEditor` (from hook) with `editor` (prop) and ignores the `block` prop. If the cursor position differs from the block this menu targets, blocks will be inserted in the wrong location. Consider using the `block` prop consistently:
```typescript
editor.insertBlocks([{ type: &#39;paragraph&#39; }], block, &#39;after&#39;);
```</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/twenty-front/src/modules/page-layout/widgets/components/WidgetRenderer.tsx

...modules/page-layout/widgets/standalone-rich-text/components/DashboardBlockDragHandleMenu.tsx

…ontend

...rc/modules/command-menu/pages/page-layout/components/CommandMenuPageLayoutIframeSettings.tsx

...modules/page-layout/widgets/standalone-rich-text/components/DashboardBlockDragHandleMenu.tsx

...front/src/modules/page-layout/widgets/standalone-rich-text/components/DashboardColorIcon.tsx

bosiraphael · 2025-12-12T13:32:12Z

.../src/modules/page-layout/widgets/standalone-rich-text/components/DashboardEditorSideMenu.tsx

+  align-items: center;
+`;
+
+const StyledDragHandleContainer = styled.div`


I feel like it is the same component as the one inside the widgets, maybe we could have a common abstraction in ui

I too thought the same, but its not -- maybe it should be the same

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=75849-261995&t=ahtsLHKbSRVWeXBF-0

.../src/modules/page-layout/widgets/standalone-rich-text/components/DashboardEditorSideMenu.tsx

...c/modules/page-layout/widgets/standalone-rich-text/components/DashboardFormattingToolbar.tsx

packages/twenty-front/src/modules/ui/input/editor/hooks/useAttachmentSync.ts

…ontend

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx

+    | StandaloneRichTextConfiguration
+    | undefined;
+
+  const currentBody = configuration?.body?.blocknote ?? '';


packages/twenty-front/src/modules/ui/input/editor/utils/prepareBodyWithSignedUrls.ts

+    }
+
+    const imageUrl = block.props.url;
+    const parsedImageUrl = new URL(imageUrl);


…ontend

...age-layout/widgets/standalone-rich-text/components/DashboardFormattingToolbarColorButton.tsx

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx

+    | StandaloneRichTextConfiguration
+    | undefined;
+
+  const currentBody = configuration?.body?.blocknote ?? '';


…ontend

...c/modules/page-layout/widgets/standalone-rich-text/components/DashboardFormattingToolbar.tsx

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx

bosiraphael

LGTM 🚀

twenty-eng-sync · 2025-12-12T17:37:12Z

Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Likely a missing lazy load in: #16437 Let's unblock and fix separately

ehconitin added 15 commits December 4, 2025 20:10

hasty commit

a7b8179

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

44004dd

…ontend

cleanup

8a6946e

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

71603c9

…ontend

continue

332f7db

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

c4362d7

…ontend

Revert "continue"

e1b12ba

This reverts commit 332f7db.

get rid of rich text side panel settings

93dab2e

continue

56a20fa

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

ec06fec

…ontend

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

c7c7d62

…ontend

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

c3cbe0b

…ontend

abstract common utils and attachments hooks

9317848

weird flex bug

435d9c0

excludeslash items

e19fb8e

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

cubic-dev-ai bot reviewed Dec 9, 2025

View reviewed changes

...es/twenty-front/src/modules/page-layout/hooks/useCreatePageLayoutStandaloneRichTextWidget.ts Outdated Show resolved Hide resolved

packages/twenty-front/src/modules/ui/input/editor/utils/parseInitialBlocknote.ts Outdated Show resolved Hide resolved

ehconitin added 4 commits December 9, 2025 22:29

fix

b0f09f3

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

99fdc27

…ontend

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

df36cf5

…ontend

small css tweaks

6454a47

ehconitin self-assigned this Dec 10, 2025

ehconitin added the -PR: awaiting author label Dec 10, 2025

ehconitin added 6 commits December 10, 2025 14:20

subtle asbtarction

45ffffc

fix multiple instances bug + add a ctoolbar controller + sepertae blo…

9c655a4

…cknote editor for dashbaords

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

e05f11f

…ontend

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

2246842

…ontend

continue

6290801

continue

f53c3c7

ehconitin added -PR: awaiting review and removed -PR: awaiting author labels Dec 12, 2025

cubic-dev-ai bot reviewed Dec 12, 2025

View reviewed changes

packages/twenty-front/src/modules/page-layout/widgets/components/WidgetRenderer.tsx Outdated Show resolved Hide resolved

...modules/page-layout/widgets/standalone-rich-text/components/DashboardBlockDragHandleMenu.tsx Outdated Show resolved Hide resolved

ehconitin added 5 commits December 12, 2025 17:20

typo

6a19d45

fix

882b337

add isDefined

4e6c330

more nit picks

00f4cef

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

f119894

…ontend

bosiraphael reviewed Dec 12, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

9975665

…ontend

sentry bot reviewed Dec 12, 2025

View reviewed changes

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx

| StandaloneRichTextConfiguration

| undefined;

const currentBody = configuration?.body?.blocknote ?? '';

This comment was marked as outdated.

Sign in to view

create color map

41be21a

sentry bot reviewed Dec 12, 2025

View reviewed changes

packages/twenty-front/src/modules/ui/input/editor/utils/prepareBodyWithSignedUrls.ts

}

const imageUrl = block.props.url;

const parsedImageUrl = new URL(imageUrl);

This comment was marked as outdated.

Sign in to view

ehconitin added 3 commits December 12, 2025 19:53

remove callback and memo

85b094d

extract offsets and paddings to consts

3f84b9f

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

c15b4c8

…ontend

bosiraphael reviewed Dec 12, 2025

View reviewed changes

...age-layout/widgets/standalone-rich-text/components/DashboardFormattingToolbarColorButton.tsx Outdated Show resolved Hide resolved

ehconitin added 2 commits December 12, 2025 22:31

fix hide handle

4ccdf86

remove usecallback

8091aec

sentry bot reviewed Dec 12, 2025

View reviewed changes

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx

| StandaloneRichTextConfiguration

| undefined;

const currentBody = configuration?.body?.blocknote ?? '';

This comment was marked as outdated.

Sign in to view

ehconitin added 2 commits December 12, 2025 22:37

use isString guard

9807c52

Merge remote-tracking branch 'upstream/main' into rich-text-editor-fr…

de055d9

…ontend

sentry bot reviewed Dec 12, 2025

View reviewed changes

...c/modules/page-layout/widgets/standalone-rich-text/components/DashboardFormattingToolbar.tsx Show resolved Hide resolved

...src/modules/page-layout/widgets/standalone-rich-text/components/StandaloneRichTextWidget.tsx Show resolved Hide resolved

bosiraphael approved these changes Dec 12, 2025

View reviewed changes

ehconitin merged commit 44f0cfd into main Dec 12, 2025
62 checks passed

ehconitin deleted the rich-text-editor-frontend branch December 12, 2025 17:37

charlesBochet mentioned this pull request Dec 15, 2025

Increase bundle size to 6.9MB #16568

Merged

charlesBochet added a commit that referenced this pull request Dec 15, 2025

Increase bundle size to 6.9MB (#16568)

4281a71

Likely a missing lazy load in: #16437 Let's unblock and fix separately

Conversation

ehconitin commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODOs/FIXMEs:

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot commented Dec 12, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bosiraphael Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

ehconitin Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

bosiraphael left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twenty-eng-sync bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ehconitin commented Dec 9, 2025 •

edited

Loading

github-actions bot commented Dec 9, 2025 •

edited

Loading