Facebook links: display profile instead of full url#16414
Facebook links: display profile instead of full url#16414charlesBochet merged 3 commits intomainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Bonapara
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds support for Facebook links to display the profile/page identifier instead of the full URL, following the existing pattern used for LinkedIn and Twitter links.
Key changes:
- Added
Facebooktype to theLinkTypeenum - Implemented Facebook URL detection and profile extraction logic
- Updated all display components to handle Facebook links as social links
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/twenty-ui/src/navigation/link/components/SocialLink.tsx | Added Facebook to the LinkType enum |
| packages/twenty-ui/src/utilities/utils/getDisplayValueByUrlType.ts | Added Facebook URL parsing logic to extract profile identifier |
| packages/twenty-front/src/utils/checkUrlType.ts | Added Facebook URL detection pattern |
| packages/twenty-front/src/utils/getDisplayValueByUrlType.ts | Added Facebook URL parsing logic (duplicate of twenty-ui version) |
| packages/twenty-front/src/modules/ui/field/display/components/URLDisplay.tsx | Updated condition to treat Facebook URLs as social links |
| packages/twenty-front/src/modules/ui/field/display/components/LinksDisplay.tsx | Updated condition to render Facebook links with SocialLink component |
| packages/twenty-front/src/modules/ui/field/display/components/LinkDisplay.tsx | Added Facebook detection and updated condition for social link rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:1455 This environment will automatically shut down when the PR is closed or after 5 hours. |
packages/twenty-front/src/modules/ui/field/display/components/LinkDisplay.tsx
Outdated
Show resolved
Hide resolved
|
Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Like we do for LinkedIn/Twitter