Remove failing workflow when already started

[charlesBochet]

This is a temporary fix that needs to be revisited.

It seems that with the new enqueue system we are enqueuing jobs multiple times due to race condition. We likely want to only consider job that have been created more than x secs ago

[greptile-apps]

Greptile Overview

Greptile Summary

Removed a redundant exception-throwing check in startWorkflowRun that was throwing a WorkflowRunException when attempting to start an already-completed or failed workflow run.

• The check for COMPLETED or FAILED statuses was unnecessary because the subsequent condition (lines 153-158) already handles all non-startable states by returning early
• This change makes the behavior more graceful: instead of throwing an exception that would fail the calling job, it now silently returns, making the operation idempotent
• The remaining status check correctly handles all seven workflow states: only NOT_STARTED and ENQUEUED states proceed to transition to RUNNING

Confidence Score: 5/5

• This PR is safe to merge - it removes redundant code while maintaining correct behavior.
• The change removes a redundant check that was already handled by the subsequent condition. The functional behavior is preserved (workflows in terminal states cannot be started), but the handling is now more graceful (early return vs exception). The code is simple and the change is minimal.
• No files require special attention.

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run/workflow-run.workspace-service.ts	5/5	Removed redundant exception-throwing check for already ended workflows. The remaining early-return check adequately handles all non-startable states.

Sequence Diagram

sequenceDiagram
    participant Job as RunWorkflowJob
    participant Service as WorkflowRunWorkspaceService
    participant DB as Database
    
    Job->>Service: startWorkflowRun(workflowRunId, workspaceId)
    Service->>DB: getWorkflowRunOrFail()
    DB-->>Service: workflowRun
    
    alt status is COMPLETED, FAILED, RUNNING, STOPPING, or STOPPED
        Note over Service: Early return (no-op)<br/>Previously threw exception for COMPLETED/FAILED
        Service-->>Job: return (silent)
    else status is ENQUEUED or NOT_STARTED
        Service->>DB: updateWorkflowRun(status: RUNNING)
        Service-->>Job: return
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[twenty-eng-sync]

Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:15833

This environment will automatically shut down when the PR is closed or after 5 hours.