Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryExtended cookie storage duration from 7 days to 180 days to match Notion's approach and resolve the mismatch where Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant Frontend
participant CookieStorage
participant Backend
User->>Frontend: Login/Authentication
Frontend->>Backend: Request access token
Backend-->>Frontend: Return access token (expires in 30m-90d)
Frontend->>CookieStorage: Store token via cookieStorageEffect
Note over CookieStorage: Cookie expires: 7 days → 180 days
CookieStorage-->>Browser: Set cookie with expiration
Note over User,Browser: Days pass (e.g., 30 days)
User->>Frontend: Return to app
Browser->>CookieStorage: Check cookie validity
alt Cookie still valid (after PR)
CookieStorage-->>Frontend: Return stored token
Frontend->>Backend: Use token
Backend-->>Frontend: Authorize request
Frontend-->>User: User remains logged in
else Cookie expired (before PR)
CookieStorage-->>Frontend: Cookie expired
Frontend-->>User: Redirect to login
Note over User: Premature logout despite<br/>valid access token
end
|
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:14581 This environment will automatically shut down when the PR is closed or after 5 hours. |
NotYen
pushed a commit
to NotYen/twenty-ym
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set it to 180 days like Notion does.
Currently Access Token Expires In is set to 90 days but this setting is ignored because the cookie is cleared after 7 days