fixed: Links in note preview not visible #16043 by piyush-rj · Pull Request #16267 · twentyhq/twenty

piyush-rj · 2025-12-02T23:24:48Z

This PR fixes an issue where links added inside a note were not appearing in the preview shown under Company -> Notes. The link would only appear after opening the note, which led to inconsistent behavior.

Issue:
Blocknote represents text and links using different node types:

{ "type": "text", "text": "Welcome to this demo!" }
{
"type": "link",
"content": { "type": "text", "text": "Example" },
"href": "https://example.com"
}

The existing preview function only handled plain text nodes and completely ignored link nodes.
As a result:

Links did not appear in the preview
Links appeared only inside the full note view

Steps to Reproduce:

Add a link inside a note
Go to Company / People and view the note preview -> the link is missing
Open the note -> the link appears correctly

How I fixed it:

A new recursive text extraction function (extractText) was added to correctly read.
Text nodes
Link nodes (including inner content and the href)
Nested child content
Link previews now appear in the following format:
DisplayText (https://example.com)

Edit : closes #16043

greptile-apps · 2025-12-02T23:29:17Z

Greptile Overview

Greptile Summary

This PR successfully fixes the missing link preview issue by introducing a recursive extractText function that handles text nodes, link nodes, and nested content structures.

Key Changes:

Replaced simple content mapping with recursive text extraction
Link nodes now render as "DisplayText (https://example.com)" in previews
Handles nested content arrays recursively

Issues Found:

Uses any type in 4 locations, violating the codebase's strict TypeScript policy (no any allowed per typescript-guidelines.mdc)
Minor indentation inconsistency on line 10
No test cases added for the new link extraction functionality (existing tests only cover text and image nodes)

Confidence Score: 3/5

This PR is functional but has TypeScript violations that must be fixed before merging
The implementation correctly solves the link preview issue and the logic is sound. However, it violates the codebase's strict TypeScript guidelines by using any types in multiple places (lines 6, 15, 32), which is explicitly prohibited. The indentation inconsistency and missing test coverage for the new functionality are also concerns. These are fixable issues but should be addressed before merging.
packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts requires TypeScript type fixes and test additions

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts	3/5	added recursive text extraction for links; violates TypeScript strict mode with `any` types; missing test coverage for links

Sequence Diagram

sequenceDiagram
    participant NoteTile
    participant getActivityPreview
    participant extractText
    participant BlocknoteNode

    NoteTile->>getActivityPreview: activityBody (JSON string)
    getActivityPreview->>getActivityPreview: JSON.parse(activityBody)
    
    loop For each block in noteBody
        getActivityPreview->>extractText: node
        
        alt node.type === 'text'
            extractText-->>getActivityPreview: node.text
        else node.type === 'link'
            extractText->>extractText: recursively extract inner text
            extractText->>extractText: format as "innerText (href)"
            extractText-->>getActivityPreview: formatted link text
        else node has content array
            loop For each child in node.content
                extractText->>extractText: recursively extract child text
            end
            extractText-->>getActivityPreview: joined child text
        else
            extractText-->>getActivityPreview: empty string
        end
    end
    
    getActivityPreview->>getActivityPreview: filter empty strings
    getActivityPreview->>getActivityPreview: join with newlines
    getActivityPreview-->>NoteTile: preview text with links

greptile-apps

_{1 file reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

github-actions · 2025-12-02T23:36:40Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:33758

This environment will automatically shut down when the PR is closed or after 5 hours.

etiennejouan

Hi @piyush-rj, congrats for your first PR !! 👏
Good job, I took the liberty of updating the PR as it is small update.

Thank you for your contribution 🙏
Please, do not hesitate to tackle other issues.

etiennejouan · 2025-12-03T16:11:08Z

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

@@ -1,16 +1,56 @@
-// TODO: merge with getFirstNonEmptyLineOfRichText (and one duplicate I saw and also added a note on)


Rem : Not sure we can remove this TODO

etiennejouan · 2025-12-03T16:12:47Z

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

@@ -1,16 +1,56 @@
-// TODO: merge with getFirstNonEmptyLineOfRichText (and one duplicate I saw and also added a note on)
+// Basic Rich-Text Node Types


nit : We avoid comment (in Twenty codebase). If you want to specify what is BaseNode, do not hesitate to be verbose :)

etiennejouan · 2025-12-03T16:14:31Z

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

@@ -1,16 +1,56 @@
-// TODO: merge with getFirstNonEmptyLineOfRichText (and one duplicate I saw and also added a note on)
+// Basic Rich-Text Node Types
+export interface BaseNode {


nit : Do not export these type if they are not used elsewhere. And if in future, they are used in an other file, export them from their own file

etiennejouan · 2025-12-03T16:32:03Z

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

+
+    switch (node.type) {
+      case 'text':
+        return (node as TextNode).text ?? '';


nit : I prefer using type guard to avoid casting - not very useful here but good habit to take

etiennejouan · 2025-12-03T16:32:54Z

packages/twenty-front/src/modules/activities/utils/getActivityPreview.ts

+          .map(child => extractText(child))
+          .join('');
+        const href = linkNode.href ?? '';
+        return href ? `${innerText} (${href})` : innerText;


I think we don't want to preview href as we don't see it in editor view

twenty-eng-sync · 2025-12-03T18:23:18Z

Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

fixed: Links in note preview not visible twentyhq#16043

80b8336

greptile-apps bot reviewed Dec 2, 2025

View reviewed changes

piyush-rj mentioned this pull request Dec 2, 2025

Links in note preview not visible #16043

Closed

charlesBochet added the -PR: awaiting review label Dec 3, 2025

fixed type errors

a7f1677

piyush-rj force-pushed the fix-issue-16043 branch from 943f858 to a7f1677 Compare December 3, 2025 09:19

Merge branch 'main' into fix-issue-16043

e06d300

etiennejouan self-assigned this Dec 3, 2025

update

ab98c97

etiennejouan approved these changes Dec 3, 2025

View reviewed changes

charlesBochet merged commit 9c334b5 into twentyhq:main Dec 3, 2025
61 checks passed

NotYen pushed a commit to NotYen/twenty-ym that referenced this pull request Dec 9, 2025

fixed: Links in note preview not visible twentyhq#16043 (twentyhq#16267)

7f76de9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed: Links in note preview not visible #16043#16267

fixed: Links in note preview not visible #16043#16267
charlesBochet merged 4 commits intotwentyhq:mainfrom
piyush-rj:fix-issue-16043

piyush-rj commented Dec 2, 2025 •

edited by etiennejouan

Loading

Uh oh!

greptile-apps bot commented Dec 2, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

etiennejouan left a comment

Uh oh!

etiennejouan Dec 3, 2025

Uh oh!

etiennejouan Dec 3, 2025

Uh oh!

etiennejouan Dec 3, 2025

Uh oh!

etiennejouan Dec 3, 2025

Uh oh!

etiennejouan Dec 3, 2025

Uh oh!

Uh oh!

twenty-eng-sync bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,16 +1,56 @@
		// TODO: merge with getFirstNonEmptyLineOfRichText (and one duplicate I saw and also added a note on)

		@@ -1,16 +1,56 @@
		// TODO: merge with getFirstNonEmptyLineOfRichText (and one duplicate I saw and also added a note on)
		// Basic Rich-Text Node Types

Conversation

piyush-rj commented Dec 2, 2025 • edited by etiennejouan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Dec 2, 2025

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etiennejouan left a comment

Choose a reason for hiding this comment

Uh oh!

etiennejouan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

etiennejouan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

etiennejouan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

etiennejouan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

etiennejouan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twenty-eng-sync bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

piyush-rj commented Dec 2, 2025 •

edited by etiennejouan

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading