Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a bug where the Changes:
Impact:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant UploadStep
participant useDownloadFakeRecords
participant FilterUtil as spreadsheetImportFilterAvailableFieldMetadataItems
participant CSV as CSV File
participant ImportDialog
participant BatchCreate
Note over User,BatchCreate: Sample CSV Generation Flow
User->>UploadStep: Click "Download Sample"
UploadStep->>useDownloadFakeRecords: downloadSample()
useDownloadFakeRecords->>FilterUtil: Filter updatableFields
Note over FilterUtil: Excludes: createdAt, updatedAt, deletedAt
FilterUtil-->>useDownloadFakeRecords: Filtered field list
useDownloadFakeRecords->>useDownloadFakeRecords: buildTableWithFakeRecords()
useDownloadFakeRecords->>CSV: Generate CSV with headers & sample data
CSV-->>User: Download sample.csv
Note over User,BatchCreate: CSV Import Flow
User->>User: Fill in CSV with data
User->>ImportDialog: Upload filled CSV
ImportDialog->>FilterUtil: Filter updatableFields
Note over FilterUtil: Without fix: deletedAt included → soft-deleted records
Note over FilterUtil: With fix: deletedAt excluded → active records
FilterUtil-->>ImportDialog: Filtered field list
ImportDialog->>BatchCreate: Create records
BatchCreate-->>User: Records imported successfully
|
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:4670 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Dec 2, 2025
|
Hey @lucasbordeau! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
NotYen
pushed a commit
to NotYen/twenty-ym
that referenced
this pull request
Dec 4, 2025
This PR fixes a bug that created a deletedAt column in sample CSV file generated for import, that when used afterwards for import, would create soft deleted records, which gives the impression that the CSV import does not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that created a deletedAt column in sample CSV file generated for import, that when used afterwards for import, would create soft deleted records, which gives the impression that the CSV import does not work.