Skip to content

i18n - translations#16250

Merged
FelixMalfait merged 2 commits intomainfrom
i18n
Dec 2, 2025
Merged

i18n - translations#16250
FelixMalfait merged 2 commits intomainfrom
i18n

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Dec 2, 2025

Created by Github action

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 2, 2025

Greptile Overview

Greptile Summary

This PR removes 9 unused translation keys from all locale files across the codebase. The removed translations were related to metadata validation utilities that are no longer in use:

  • {name} should be in camelCase
  • Input is too short: "{name}"
  • Invalid object metadata input
  • Name "{computedMetadataNameFromLabel}" cannot be the same on both side of the relation
  • Name is not available, it may be duplicating another field's name.
  • Name is too long: it exceeds the 63 characters limit.
  • String "{name}" is not valid: must start with lowercase letter and contain only alphanumeric letters
  • This name is not available as it is already used by another field.
  • This name is not available.

The changes were automatically generated by the GitHub Actions workflow that extracts and compiles translations using @lingui. All 31 locale files (.po) were cleaned up consistently, and their corresponding compiled TypeScript files (.ts) were regenerated with the reduced translation set.

Confidence Score: 5/5

  • This PR is completely safe to merge with no risk
  • This is an automated cleanup of unused translation keys generated by the lingui extraction tool. All changes are mechanical and consistent: exactly 9 unused translation entries were removed from all 31 locale files, and the corresponding compiled TypeScript files were regenerated automatically. The changes reduce bundle size and maintain code cleanliness without any functional impact.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-server/src/engine/core-modules/i18n/locales/en.po 5/5 Removed 9 unused translation keys from English locale source file
packages/twenty-server/src/engine/core-modules/i18n/locales/generated/en.ts 5/5 Regenerated compiled translations without removed keys, file size decreased by ~700 bytes
packages/twenty-server/src/engine/core-modules/i18n/locales/fr-FR.po 5/5 Removed same 9 unused translation keys from French locale source file
packages/twenty-server/src/engine/core-modules/i18n/locales/generated/fr-FR.ts 5/5 Regenerated French compiled translations without removed keys
packages/twenty-server/src/engine/core-modules/i18n/locales/de-DE.po 5/5 Removed same 9 unused translation keys from German locale source file
packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po 5/5 Removed same 9 unused translation keys from Japanese locale source file

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Repo as Repository
    participant Lingui as @lingui/cli
    participant PO as .po Files
    participant TS as Generated .ts Files

    Note over GHA,TS: Translation Extraction & Compilation Workflow
    
    GHA->>Repo: Checkout i18n branch
    GHA->>Repo: Install dependencies
    GHA->>Lingui: Run lingui:extract
    Lingui->>Repo: Scan source code for translation keys
    Lingui->>PO: Remove unused translation entries
    Note over PO: 9 unused keys removed from<br/>all 31 locale files
    GHA->>Repo: Commit extracted translations
    
    GHA->>Lingui: Run lingui:compile
    Lingui->>PO: Read updated .po files
    Lingui->>TS: Generate minified TypeScript exports
    Note over TS: JSON.parse() with compiled messages<br/>File sizes reduced by ~700 bytes
    GHA->>Repo: Commit compiled translations
    
    GHA->>Repo: Push to i18n branch
    GHA->>Repo: Create/Update PR to main
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@FelixMalfait FelixMalfait merged commit 5d4170d into main Dec 2, 2025
8 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch December 2, 2025 11:46
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Dec 2, 2025

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:6433:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6414:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5380:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-9e4c0b47.json

Generated by 🚫 dangerJS against e36e2fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant