Skip to content

i18n - translations#16223

Merged
FelixMalfait merged 2 commits intomainfrom
i18n
Dec 1, 2025
Merged

i18n - translations#16223
FelixMalfait merged 2 commits intomainfrom
i18n

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Dec 1, 2025

Created by Github action

@FelixMalfait FelixMalfait merged commit 670d6ce into main Dec 1, 2025
8 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch December 1, 2025 17:21
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Dec 1, 2025

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:6433:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6414:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5380:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-ed6302a0.json

Generated by 🚫 dangerJS against 6dc7205

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

This PR adds a new translation string for displaying filter rule counts in chart settings. The string uses plural forms to correctly display "1 rule" vs "N rules" across all supported locales.

Key changes:

  • New translation entry bv2QCV added to all 31 .po source files for the filter rules count plural form
  • All 31 generated TypeScript files updated with the compiled translation
  • Translation string properly implements ICU MessageFormat plural syntax
  • English translation is complete; all other locales have empty msgstr values awaiting community translations

Notes:

  • Empty translations in non-English locales will fall back to the English string until translated
  • All generated TypeScript files follow the expected minified JSON format
  • Changes are purely additive with no modifications to existing translations

Confidence Score: 5/5

  • This PR is safe to merge with no risk. It contains only automated translation file updates.
  • Score reflects that this is an automated i18n update generated by the translation extraction process. All changes follow the expected pattern: new translation entries added consistently across all locale files, generated TypeScript files properly updated, and no functional code changes. The empty translations in non-English locales are expected and will fall back to English until translated by the community.
  • No files require special attention. This is a standard automated translation update.

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/locales/en.po 5/5 Added new plural translation string for filter rules count. Translation extraction is correct.
packages/twenty-front/src/locales/fr-FR.po 4/5 Added new translation entry but msgstr is empty, awaiting French translation.
packages/twenty-front/src/locales/de-DE.po 4/5 Added new translation entry but msgstr is empty, awaiting German translation.
packages/twenty-front/src/locales/es-ES.po 4/5 Added new translation entry but msgstr is empty, awaiting Spanish translation.
packages/twenty-front/src/locales/generated/en.ts 5/5 Generated TypeScript file updated with new translation key bv2QCV in minified JSON format.
packages/twenty-front/src/locales/generated/fr-FR.ts 5/5 Generated TypeScript file updated consistently with source .po file changes.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Code as Source Code
    participant Extract as Translation Extractor
    participant PO as .po Files
    participant Compile as Translation Compiler
    participant TS as Generated .ts Files

    Dev->>Code: Add plural() call in useChartSettingsValues.ts
    Dev->>Extract: Run extraction command
    Extract->>Code: Scan source files for translation strings
    Extract->>PO: Add new msgid entries to all 31 .po files
    Note over PO: English: complete msgstr<br/>Others: empty msgstr
    Dev->>Compile: Run compilation command
    Compile->>PO: Read all .po translation files
    Compile->>TS: Generate 31 TypeScript files with JSON.parse()
    Note over TS: Minified JSON format<br/>with translation key bv2QCV
    Dev->>Dev: Commit changes via GitHub Action
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant