Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR updates translation files following a UI change in PR #16193 that replaced the "Download sample file." text link with a "Download sample" button in the CSV import upload step. Changes:
Issues found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Code as DropZone.tsx
participant Extract as Translation Extraction
participant PO as .po files
participant Compile as Compilation
participant TS as generated/*.ts files
Note over Dev,Code: PR #16193: UI Change
Dev->>Code: Change "Download sample file." to "Download sample"
Note over Extract,PO: PR #16220: Translation Update
Extract->>PO: Extract new source string
Extract->>PO: Generate new message ID (BU+6gf)
Extract->>PO: Clear all translations (msgstr "")
Compile->>TS: Regenerate TypeScript files
TS->>TS: Update all 31 locale files
Note over PO: Awaiting retranslation for 31 languages
|
| #: src/modules/spreadsheet-import/steps/components/UploadStep/components/DropZone.tsx | ||
| msgid "Download sample file." | ||
| msgstr "Télécharger le fichier d'exemple." | ||
| msgid "Download sample" |
Contributor
There was a problem hiding this comment.
logic: missing French translation - should be "Télécharger l'exemple" or similar short form
Suggested change
| msgid "Download sample" | |
| msgstr "Télécharger l'exemple" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/twenty-front/src/locales/fr-FR.po
Line: 3381:3381
Comment:
**logic:** missing French translation - should be "Télécharger l'exemple" or similar short form
```suggestion
msgstr "Télécharger l'exemple"
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
LogDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action