Skip to content

i18n - translations#16220

Merged
FelixMalfait merged 2 commits intomainfrom
i18n
Dec 1, 2025
Merged

i18n - translations#16220
FelixMalfait merged 2 commits intomainfrom
i18n

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Dec 1, 2025

Created by Github action

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

This PR updates translation files following a UI change in PR #16193 that replaced the "Download sample file." text link with a "Download sample" button in the CSV import upload step.

Changes:

  • Updated source string in en.po from "Download sample file." to "Download sample"
  • Changed lingui message ID from wrT4hq to BU+6gf
  • Cleared translations in all locale files (31 languages) - translations now show empty msgstr "" and need to be retranslated
  • Regenerated all TypeScript locale files (generated/*.ts) to reflect the changes

Issues found:

  • All non-English translations are now missing/empty for this string and will display the English fallback until retranslated

Confidence Score: 4/5

  • Safe to merge - automated translation update with missing translations that will use English fallback
  • Score reflects that this is an automated, low-risk translation extraction following a UI change. The only concern is that 31 languages have empty translations and will display English text until retranslated, which is a temporary UX degradation but not a functional issue.
  • All non-English .po files need translations added for the "Download sample" string (currently empty)

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/locales/en.po 5/5 updated source string from "Download sample file." to "Download sample" to match UI button text change
packages/twenty-front/src/locales/fr-FR.po 4/5 cleared translation for "Download sample" - needs retranslation from "Télécharger le fichier d'exemple."
packages/twenty-front/src/locales/de-DE.po 4/5 cleared translation for "Download sample" - needs retranslation from "Beispieldatei herunterladen."
packages/twenty-front/src/locales/es-ES.po 4/5 cleared translation for "Download sample" - needs retranslation from "Descargar archivo de ejemplo."
packages/twenty-front/src/locales/generated/en.ts 5/5 automatically regenerated TypeScript file with updated message ID for "Download sample"
packages/twenty-front/src/locales/generated/fr-FR.ts 5/5 automatically regenerated TypeScript file reflecting cleared French translation

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Code as DropZone.tsx
    participant Extract as Translation Extraction
    participant PO as .po files
    participant Compile as Compilation
    participant TS as generated/*.ts files
    
    Note over Dev,Code: PR #16193: UI Change
    Dev->>Code: Change "Download sample file." to "Download sample"
    
    Note over Extract,PO: PR #16220: Translation Update
    Extract->>PO: Extract new source string
    Extract->>PO: Generate new message ID (BU+6gf)
    Extract->>PO: Clear all translations (msgstr "")
    
    Compile->>TS: Regenerate TypeScript files
    TS->>TS: Update all 31 locale files
    
    Note over PO: Awaiting retranslation for 31 languages
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

#: src/modules/spreadsheet-import/steps/components/UploadStep/components/DropZone.tsx
msgid "Download sample file."
msgstr "Télécharger le fichier d'exemple."
msgid "Download sample"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: missing French translation - should be "Télécharger l'exemple" or similar short form

Suggested change
msgid "Download sample"
msgstr "Télécharger l'exemple"
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/twenty-front/src/locales/fr-FR.po
Line: 3381:3381

Comment:
**logic:** missing French translation - should be "Télécharger l'exemple" or similar short form

```suggestion
msgstr "Télécharger l'exemple"
```

How can I resolve this? If you propose a fix, please make it concise.

@FelixMalfait FelixMalfait merged commit c51a4a1 into main Dec 1, 2025
8 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch December 1, 2025 16:40
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Dec 1, 2025

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:6433:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6414:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5380:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-7ecd9fb2.json

Generated by 🚫 dangerJS against 5597dbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant