Skip to content

Null equivalence - Activate FF for all#16209

Merged
Weiko merged 3 commits intomainfrom
ej/null-equivalence-ff-for-all
Dec 1, 2025
Merged

Null equivalence - Activate FF for all#16209
Weiko merged 3 commits intomainfrom
ej/null-equivalence-ff-for-all

Conversation

@etiennejouan
Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

Enabled the IS_NULL_EQUIVALENCE_ENABLED feature flag for all newly seeded workspaces in development environments. This feature flag controls whether the system treats empty strings and empty arrays as NULL values instead of using default values.

Key changes:

  • Added IS_NULL_EQUIVALENCE_ENABLED feature flag entry to the seeding utility
  • Flag is set to true by default for all seeded workspaces
  • Aligns with the migration command that cleans null-equivalent values and enables this flag for existing workspaces

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is straightforward and follows the existing pattern for feature flag seeding. It adds a single feature flag entry that is already defined in the enum and used throughout the codebase. The flag controls null equivalence behavior that has been tested in other parts of the system via the migration command.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts 5/5 Enabled IS_NULL_EQUIVALENCE_ENABLED feature flag for all seeded workspaces

Sequence Diagram

sequenceDiagram
    participant DS as DevSeeder
    participant SF as seedFeatureFlags
    participant DB as Database
    participant App as Application
    
    DS->>SF: Call seedFeatureFlags()
    SF->>DB: Insert feature flags with orIgnore()
    Note over SF,DB: IS_NULL_EQUIVALENCE_ENABLED = true
    DB-->>SF: Flags seeded
    SF-->>DS: Complete
    
    App->>DB: Check IS_NULL_EQUIVALENCE_ENABLED
    DB-->>App: Returns true
    Note over App: Converts empty strings to NULL<br/>Converts empty arrays to NULL<br/>Uses NULL instead of default values
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:1057

This environment will automatically shut down when the PR is closed or after 5 hours.

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR's name implies you want to activate this for all workspaces however this will only have an effect on dev seeder. Is it expected?

@etiennejouan
Copy link
Copy Markdown
Contributor Author

PR's name implies you want to activate this for all workspaces however this will only have an effect on dev seeder. Is it expected?

@Weiko Thanks ! You're right, I'm fixing it

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etiennejouan etiennejouan enabled auto-merge (squash) December 1, 2025 12:52
@Weiko Weiko disabled auto-merge December 1, 2025 14:43
@Weiko Weiko merged commit 638d401 into main Dec 1, 2025
58 of 61 checks passed
@Weiko Weiko deleted the ej/null-equivalence-ff-for-all branch December 1, 2025 14:43
@twenty-eng-sync
Copy link
Copy Markdown

Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants