Merged
Conversation
…o eliminate unused animation logic for side panel.
Contributor
Greptile OverviewGreptile SummarySimplified command menu animation by removing redundant x-axis slide animation from Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant CommandMenuPageLayout
participant StyledSidePanelWrapper
participant StyledSidePanel
participant CommandMenuRouter
User->>CommandMenuPageLayout: Open command menu
CommandMenuPageLayout->>CommandMenuPageLayout: isCommandMenuOpened = true
CommandMenuPageLayout->>StyledSidePanelWrapper: animate width (0 → 400px)
CommandMenuPageLayout->>StyledSidePanelWrapper: animate marginLeft (0 → spacing)
Note over StyledSidePanel: No x-axis translation (removed)
StyledSidePanelWrapper->>CommandMenuPageLayout: onAnimationStart()
CommandMenuPageLayout->>CommandMenuPageLayout: setShouldRenderContent(true)
CommandMenuPageLayout->>CommandMenuRouter: Render content
StyledSidePanelWrapper->>CommandMenuPageLayout: onAnimationComplete()
User->>CommandMenuPageLayout: Close command menu
CommandMenuPageLayout->>CommandMenuPageLayout: isCommandMenuOpened = false
CommandMenuPageLayout->>StyledSidePanelWrapper: animate width (400px → 0)
CommandMenuPageLayout->>StyledSidePanelWrapper: animate marginLeft (spacing → 0)
StyledSidePanelWrapper->>CommandMenuPageLayout: onAnimationComplete()
CommandMenuPageLayout->>CommandMenuPageLayout: setShouldRenderContent(false)
CommandMenuPageLayout->>CommandMenuPageLayout: commandMenuCloseAnimationCompleteCleanup()
|
e929b53 to
b099c95
Compare
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:4988 This environment will automatically shut down when the PR is closed or after 5 hours. |
Contributor
|
Thanks @abdulrahmancodes for your contribution! |
NotYen
pushed a commit
to NotYen/twenty-ym
that referenced
this pull request
Dec 4, 2025
https://github.com/user-attachments/assets/c9ff288d-0e68-4877-af6b-8685a6bbeeaf <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes legacy layout and refactors `CommandMenuPageLayout` to use width-based animation with shared constants and close-animation cleanup. > > - **UI/Command Menu**: > - **Refactor `CommandMenuPageLayout`**: > - Switch to width/margin animation on `StyledSidePanelWrapper`; remove side panel `x` translate animation. > - Use shared `COMMAND_MENU_SIDE_PANEL_WIDTH` constant. > - Add close-state handling via `isCommandMenuClosingState` and `useCommandMenuCloseAnimationCompleteCleanup` on animation completion. > - Simplify props: remove `isSidePanelOpen`; rely on `isCommandMenuOpenedState` and internal `shouldRenderContent`. > - **Cleanup**: > - Remove obsolete `CommandMenuLayout.tsx`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d6cb011. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Screen.Recording.2025-11-30.at.8.51.43.AM.mov
Note
Removes legacy layout and refactors
CommandMenuPageLayoutto use width-based animation with shared constants and close-animation cleanup.CommandMenuPageLayout:StyledSidePanelWrapper; remove side panelxtranslate animation.COMMAND_MENU_SIDE_PANEL_WIDTHconstant.isCommandMenuClosingStateanduseCommandMenuCloseAnimationCompleteCleanupon animation completion.isSidePanelOpen; rely onisCommandMenuOpenedStateand internalshouldRenderContent.CommandMenuLayout.tsx.Written by Cursor Bugbot for commit d6cb011. This will update automatically on new commits. Configure here.