Conversation
etiennejouan
approved these changes
Nov 28, 2025
Contributor
Greptile OverviewGreptile SummaryIncreased the main chunk size limit from 6.1MB to 6.5MB (6.5% increase) to allow the build to pass for the 1.12 release.
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Build as Vite Build Process
participant Plugin as chunk-size-limit Plugin
participant Config as vite.config.ts
Dev->>Config: Update MAIN_CHUNK_SIZE_LIMIT
Note over Config: 6.1MB → 6.5MB
Dev->>Build: Run build command
Build->>Config: Load configuration
Config-->>Build: MAIN_CHUNK_SIZE_LIMIT = 6.5MB
Build->>Build: Bundle application
Build->>Plugin: generateBundle()
Plugin->>Plugin: Check each chunk size
alt Chunk size > limit
Plugin->>Build: error(oversized chunks)
Build->>Dev: Build failed
else Chunk size <= limit
Plugin->>Build: Continue
Build->>Dev: Build successful
end
|
Comment on lines
45
to
+48
| // Please don't increase this limit for main index chunk | ||
| // If it gets too big then find modules in the code base | ||
| // that can be loaded lazily, there are more! | ||
| const MAIN_CHUNK_SIZE_LIMIT = 6.1 * 1024 * 1024; // 6.1MB for main index chunk | ||
| const MAIN_CHUNK_SIZE_LIMIT = 6.5 * 1024 * 1024; // 6.5MB for main index chunk |
Contributor
There was a problem hiding this comment.
style: this change directly contradicts the comment above which explicitly states "Please don't increase this limit for main index chunk". The comment suggests finding modules that can be loaded lazily instead of increasing the limit. Have you investigated lazy loading options before increasing the chunk size?
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/twenty-front/vite.config.ts
Line: 45:48
Comment:
**style:** this change directly contradicts the comment above which explicitly states "Please don't increase this limit for main index chunk". The comment suggests finding modules that can be loaded lazily instead of increasing the limit. Have you investigated lazy loading options before increasing the chunk size?
How can I resolve this? If you propose a fix, please make it concise.
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:10400 This environment will automatically shut down when the PR is closed or after 5 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.12