Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR updates translation files across all 31 supported locales, extracting new translatable strings from recent code changes related to AI agent permissions functionality. Key changes include:
This is an automated PR generated by the i18n extraction workflow, which is standard practice for keeping translations synchronized with code changes. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GHA as GitHub Action
participant Lingui as Lingui i18n Tool
participant PO as .po Files
participant TS as Generated .ts Files
Note over GHA: Translation extraction workflow triggered
GHA->>Lingui: Extract translatable strings from source code
Lingui->>PO: Update .po files with new translation keys
Note over PO: New keys added:<br/>- AI agent permissions<br/>- CRUD operations<br/>- Role assignments
PO->>PO: Maintain existing translations
Note over PO: Non-English translations<br/>remain untranslated (empty msgstr)
Lingui->>TS: Compile .po files to TypeScript
TS->>TS: Generate optimized JSON structures
Note over GHA,TS: All 62 locale files updated
|
Comment on lines
+221
to
+229
| #. js-lingui-id: FaQB54 | ||
| #: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts | ||
| msgid "{permissionLabel} permission removed" | ||
| msgstr "{permissionLabel} permission removed" | ||
|
|
||
| #. js-lingui-id: VsXMnq | ||
| #: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts | ||
| msgid "{permissionLabel} Permission removed" | ||
| msgstr "{permissionLabel} Permission removed" |
Contributor
There was a problem hiding this comment.
style: Two duplicate translation keys with only capitalization difference: "{permissionLabel} permission removed" (lowercase 'p') and "{permissionLabel} Permission removed" (uppercase 'P'). This creates unnecessary duplication and inconsistency.
Suggested change
| #. js-lingui-id: FaQB54 | |
| #: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts | |
| msgid "{permissionLabel} permission removed" | |
| msgstr "{permissionLabel} permission removed" | |
| #. js-lingui-id: VsXMnq | |
| #: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts | |
| msgid "{permissionLabel} Permission removed" | |
| msgstr "{permissionLabel} Permission removed" | |
| #. js-lingui-id: FaQB54 | |
| #: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts | |
| msgid "{permissionLabel} permission removed" | |
| msgstr "{permissionLabel} permission removed" |
Consider using only one variant and updating the source code reference to use the same key.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/twenty-front/src/locales/en.po
Line: 221:229
Comment:
**style:** Two duplicate translation keys with only capitalization difference: `"{permissionLabel} permission removed"` (lowercase 'p') and `"{permissionLabel} Permission removed"` (uppercase 'P'). This creates unnecessary duplication and inconsistency.
```suggestion
#. js-lingui-id: FaQB54
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} permission removed"
msgstr "{permissionLabel} permission removed"
```
Consider using only one variant and updating the source code reference to use the same key.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
LogDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action