Skip to content

i18n - translations#16159

Merged
FelixMalfait merged 2 commits intomainfrom
i18n
Nov 27, 2025
Merged

i18n - translations#16159
FelixMalfait merged 2 commits intomainfrom
i18n

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Created by Github action

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Nov 27, 2025

Greptile Overview

Greptile Summary

This PR updates translation files across all 31 supported locales, extracting new translatable strings from recent code changes related to AI agent permissions functionality.

Key changes include:

  • Added new translation keys for workflow AI agent permissions features (permissions tab, CRUD operations, role management)
  • Updated file references where translation usage moved from components to hooks (e.g., SettingsRolePermissionsSettingsSection.tsxuseSettingsRolePermissionFlagConfig.ts)
  • Regenerated all compiled TypeScript translation files from updated .po sources
  • English translations are complete; non-English locales have new keys added but not yet translated (empty msgstr values)

This is an automated PR generated by the i18n extraction workflow, which is standard practice for keeping translations synchronized with code changes.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk as it contains automated translation updates
  • This is an automated i18n extraction PR that follows established patterns. The changes are mechanical: extracting new translation keys from source code, updating file references, and regenerating compiled files. The English base translations are complete and accurate. While non-English translations are pending, this is expected behavior - translators will fill these in separately. The only minor issue is a style inconsistency with duplicate keys differing only in capitalization.
  • No files require special attention - all changes follow the automated i18n extraction pattern correctly

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/locales/en.po 5/5 Added new translation strings for AI agent permissions feature (permissions tab, CRUD operations, role assignment)
packages/twenty-front/src/locales/fr-FR.po 4/5 Added new translation keys but many are not yet translated (empty msgstr values)
packages/twenty-front/src/locales/de-DE.po 4/5 Added new translation keys but many are not yet translated (empty msgstr values)
packages/twenty-front/src/locales/generated/en.ts 5/5 Regenerated compiled translation file from en.po source
packages/twenty-front/src/locales/generated/fr-FR.ts 5/5 Regenerated compiled translation file from fr-FR.po source

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Action
    participant Lingui as Lingui i18n Tool
    participant PO as .po Files
    participant TS as Generated .ts Files
    
    Note over GHA: Translation extraction workflow triggered
    GHA->>Lingui: Extract translatable strings from source code
    Lingui->>PO: Update .po files with new translation keys
    Note over PO: New keys added:<br/>- AI agent permissions<br/>- CRUD operations<br/>- Role assignments
    PO->>PO: Maintain existing translations
    Note over PO: Non-English translations<br/>remain untranslated (empty msgstr)
    Lingui->>TS: Compile .po files to TypeScript
    TS->>TS: Generate optimized JSON structures
    Note over GHA,TS: All 62 locale files updated
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +221 to +229
#. js-lingui-id: FaQB54
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} permission removed"
msgstr "{permissionLabel} permission removed"

#. js-lingui-id: VsXMnq
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} Permission removed"
msgstr "{permissionLabel} Permission removed"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Two duplicate translation keys with only capitalization difference: "{permissionLabel} permission removed" (lowercase 'p') and "{permissionLabel} Permission removed" (uppercase 'P'). This creates unnecessary duplication and inconsistency.

Suggested change
#. js-lingui-id: FaQB54
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} permission removed"
msgstr "{permissionLabel} permission removed"
#. js-lingui-id: VsXMnq
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} Permission removed"
msgstr "{permissionLabel} Permission removed"
#. js-lingui-id: FaQB54
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} permission removed"
msgstr "{permissionLabel} permission removed"

Consider using only one variant and updating the source code reference to use the same key.

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/twenty-front/src/locales/en.po
Line: 221:229

Comment:
**style:** Two duplicate translation keys with only capitalization difference: `"{permissionLabel} permission removed"` (lowercase 'p') and `"{permissionLabel} Permission removed"` (uppercase 'P'). This creates unnecessary duplication and inconsistency.

```suggestion
#. js-lingui-id: FaQB54
#: src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/hooks/useWorkflowAiAgentPermissionActions.ts
msgid "{permissionLabel} permission removed"
msgstr "{permissionLabel} permission removed"
```

Consider using only one variant and updating the source code reference to use the same key.

How can I resolve this? If you propose a fix, please make it concise.

@FelixMalfait FelixMalfait merged commit a77b9d4 into main Nov 27, 2025
8 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch November 27, 2025 22:01
@github-actions
Copy link
Copy Markdown
Contributor Author

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:6433:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6414:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5380:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-09f0b7d6.json

Generated by 🚫 dangerJS against b3d24af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant