[DASHBOARDS] Add default order by and date granularity when choosing field

[bosiraphael]

QA

CleanShot.2025-11-27.at.15.55.50.mp4

CleanShot.2025-11-27.at.15.57.44.mp4

[greptile-apps]

Greptile Overview

Greptile Summary

Refactors chart field selection to automatically set default orderBy (FIELD_ASC) and dateGranularity (DAY) when users choose a grouping field. The implementation extracts previously inline logic into a dedicated utility function buildChartGroupByFieldConfigUpdate, improving code maintainability and consistency.

• Extracted field configuration logic from ChartGroupByFieldSelectionDropdownContentBase into reusable utility
• Sets sensible defaults for primary/secondary axes and pie chart grouping fields
• Handles different chart types (bar, line, pie) with appropriate configuration properties
• Added test coverage for main scenarios

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• Clean refactoring that extracts inline logic into a well-structured utility function with good test coverage. The changes improve code maintainability without altering core behavior. No breaking changes or security concerns.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-front/src/modules/command-menu/pages/page-layout/utils/buildChartGroupByFieldConfigUpdate.ts	5/5	Extracts chart field configuration logic into a reusable utility function that sets default orderBy and dateGranularity values when fields are selected
packages/twenty-front/src/modules/command-menu/pages/page-layout/utils/tests/buildChartGroupByFieldConfigUpdate.test.ts	4/5	Adds tests for the new utility function covering primary axis, secondary axis, and pie chart scenarios
packages/twenty-front/src/modules/command-menu/pages/page-layout/components/dropdown-content/ChartGroupByFieldSelectionDropdownContentBase.tsx	5/5	Refactors inline configuration logic to use the new utility function, removing code duplication and improving maintainability

Sequence Diagram

sequenceDiagram
    participant User
    participant Dropdown as ChartGroupByFieldSelectionDropdownContentBase
    participant Util as buildChartGroupByFieldConfigUpdate
    participant Hook as useUpdateCurrentWidgetConfig
    participant Store as Widget Config Store

    User->>Dropdown: Select field from dropdown
    Dropdown->>Dropdown: handleSelectField(fieldMetadataItem)
    Dropdown->>Util: buildChartGroupByFieldConfigUpdate({configuration, keys, fieldId})
    
    alt Primary Axis
        Util->>Util: Set primaryAxisOrderBy = FIELD_ASC (if not exists)
        Util->>Util: Set primaryAxisDateGranularity = DAY (if not exists)
    else Secondary Axis (Bar Chart)
        Util->>Util: Set secondaryAxisOrderBy = FIELD_ASC (if not exists)
        Util->>Util: Set secondaryAxisGroupByDateGranularity = DAY (if not exists)
        Util->>Util: Set groupMode = STACKED (if not exists)
    else Secondary Axis (Line Chart)
        Util->>Util: Set secondaryAxisOrderBy = FIELD_ASC (if not exists)
        Util->>Util: Set secondaryAxisGroupByDateGranularity = DAY (if not exists)
        Util->>Util: Set isStacked = true (if not exists)
    else Pie Chart GroupBy
        Util->>Util: Set orderBy = FIELD_ASC (if not exists)
        Util->>Util: Set dateGranularity = DAY (if not exists)
    end
    
    Util-->>Dropdown: Return config update object
    Dropdown->>Hook: updateCurrentWidgetConfig(configToUpdate)
    Hook->>Store: Update widget configuration
    Store-->>User: Chart updates with default ordering and date granularity

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:34242

This environment will automatically shut down when the PR is closed or after 5 hours.

[ehconitin]

lgtm!