Currency input field - fix

[etiennejouan]

Currency field used to have default value, but default value on field is not mandatory. Defaulf default value logic has been removed.

Also test all field type input when empty. ✅

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed a runtime error in CurrencyFieldInput by adding optional chaining when accessing defaultValue.currencyCode, allowing currency fields to work correctly when no default value is defined.

• Added ?. operator to safely access defaultValue.currencyCode
• Prevents TypeError when currency fields lack default values

Confidence Score: 4/5

• This PR is safe to merge with one minor fix needed for the optional chaining
• The fix correctly addresses the undefined defaultValue issue, but the optional chaining doesn't fully protect against errors since .replace() will still throw if currencyCode is undefined. This is a simple syntax issue that needs one more ? added.
• Review the optional chaining on line 31 in CurrencyFieldInput.tsx - needs ?.replace() instead of .replace()

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/CurrencyFieldInput.tsx	4/5	Added optional chaining to defaultValue?.currencyCode to handle cases where defaultValue is undefined, preventing runtime errors when currency fields don't have default values

Sequence Diagram

sequenceDiagram
    participant User
    participant CurrencyFieldInput
    participant useCurrencyField
    participant FieldDefinition
    participant CurrencyInput

    User->>CurrencyFieldInput: Render component
    CurrencyFieldInput->>useCurrencyField: Get field data
    useCurrencyField-->>CurrencyFieldInput: Returns draftValue, defaultValue
    
    alt defaultValue is undefined
        CurrencyFieldInput->>CurrencyFieldInput: Optional chaining prevents error
        Note over CurrencyFieldInput: defaultCurrencyCodeWithoutSQLQuotes = undefined
    else defaultValue exists
        CurrencyFieldInput->>CurrencyFieldInput: Extract currencyCode and remove SQL quotes
        Note over CurrencyFieldInput: defaultCurrencyCodeWithoutSQLQuotes = value
    end
    
    CurrencyFieldInput->>CurrencyFieldInput: Determine currencyCode (draft > default > USD)
    CurrencyFieldInput->>CurrencyInput: Render with currencyCode
    
    User->>CurrencyInput: Enter amount
    CurrencyInput->>CurrencyFieldInput: handleChange(newValue)
    CurrencyFieldInput->>useCurrencyField: setDraftValue({amount, currencyCode})

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:22768

This environment will automatically shut down when the PR is closed or after 5 hours.

[bosiraphael]

LGTM