fix(#15950): mobile favorites folder navigation with proper back button#16118
Merged
Weiko merged 11 commits intotwentyhq:mainfrom Dec 3, 2025
Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryImplements mobile-specific navigation for favorite folders by introducing drill-down behavior instead of accordion expansion. When users tap a folder on mobile, it now opens a dedicated view showing only that folder's contents with a back button to return. Key changes:
Issues found:
Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant NavigationDrawer
participant FavoriteFolder
participant State as currentFavoriteFolderIdState
participant Content as FavoritesFolderContent
participant BackButton as FavoritesBackButton
Note over User,BackButton: Mobile Folder Navigation Flow
User->>FavoriteFolder: Click folder item
FavoriteFolder->>FavoriteFolder: Check isMobile
alt Mobile Device
FavoriteFolder->>State: setCurrentFolderId(folderId)
State-->>NavigationDrawer: State updated
NavigationDrawer->>NavigationDrawer: Check currentFavoriteFolderId
NavigationDrawer->>Content: Render FavoritesFolderContent
Content->>BackButton: Render FavoritesBackButton
Content->>Content: Render folder favorites
Note over Content: Uses NavigationDrawerItem (not SubItem)
else Desktop
FavoriteFolder->>FavoriteFolder: setOpenFavoriteFolderIds
Note over FavoriteFolder: Accordion expands inline
end
User->>BackButton: Click back button
BackButton->>State: setCurrentFolderId(null)
State-->>NavigationDrawer: State cleared
NavigationDrawer->>NavigationDrawer: Render MainNavigationDrawerScrollableItems
|
packages/twenty-front/src/modules/favorites/components/FavoritesFolderContent.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/favorites/components/FavoritesFolderContent.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/favorites/components/FavoritesFolderContent.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:50414 This environment will automatically shut down when the PR is closed or after 5 hours. |
…ack button (fixed drag-and-drop)
…ack button (return the provider)
Devessier
approved these changes
Dec 2, 2025
Contributor
|
@AntonAmbarov, I'm checking why we can't merge your PR. |
NotYen
pushed a commit
to NotYen/twenty-ym
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s done
NavigationDrawerBackButtonIntentional deviations from the mockup
Back button does not replace
MultiWorkspaceDropdownButtonKept
NavigationDrawerHeaderuntouched — it’s responsible for the hamburger menu and workspace name.Added the back button as a separate block below.
→ This feels cleaner architecturally and avoids breaking other places that use
NavigationDrawerHeader.Vertical spacing between items is slightly tighter than in the mockup
Used
NavigationDrawerSubItem— the standard component for nested items in Twenty.Current production spacing matches this exactly, so I preferred consistency over pixel-perfect mockup matching.
Happy to adjust either point if the team prefers to follow the mockup 1:1.
Closes #15950