Skip to content

fix: update side panel header title to base font size with baseline alignment#16095

Merged
Weiko merged 1 commit intomainfrom
fix-side-panel-header-title-style
Nov 28, 2025
Merged

fix: update side panel header title to base font size with baseline alignment#16095
Weiko merged 1 commit intomainfrom
fix-side-panel-header-title-style

Conversation

@Bonapara
Copy link
Copy Markdown
Member

@Bonapara Bonapara commented Nov 26, 2025

Summary

  1. Changed the side panel header title font size from small (0.92rem) to base (1rem)
  2. Added baseline alignment between the title and subtitle text while keeping the icon centered

Changes

  • Updated StyledPageInfoTitleContainer font size from theme.font.size.sm to theme.font.size.md
  • Added StyledPageInfoTextContainer wrapper to baseline-align title and subtitle independently from the icon
image

Copilot AI review requested due to automatic review settings November 26, 2025 14:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the typography and alignment of the side panel header by increasing the title font size and introducing baseline alignment between title and subtitle elements.

  • Updated title font size from theme.font.size.sm (0.92rem) to theme.font.size.md (1rem) for better readability
  • Introduced StyledPageInfoTextContainer wrapper to baseline-align title and subtitle independently from the icon
  • Restructured component hierarchy to separate text alignment from icon alignment
Comments suppressed due to low confidence (1)

packages/twenty-front/src/modules/command-menu/components/CommandMenuPageInfoLayout.tsx:34

  • The StyledPageInfoTitleContainer has max-width: 150px but is missing the text truncation properties needed to properly handle overflow. When text exceeds 150px, it should be truncated with an ellipsis.

Add the following properties:

overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;

This pattern is consistently used throughout the codebase when max-width is combined with text content (see examples in EllipsisDisplay.tsx, NavigationDrawerItem.tsx, Breadcrumb.tsx, etc.).

export const StyledPageInfoTitleContainer = styled.div`
  font-size: ${({ theme }) => theme.font.size.md};
  font-weight: ${({ theme }) => theme.font.weight.semiBold};
  min-width: 0;
  max-width: 150px;
`;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Nov 26, 2025

Greptile Overview

Greptile Summary

Changed side panel header title font size from sm (0.92rem) to md (1rem) and added baseline alignment between title and subtitle text.

  • Extracted StyledPageInfoTitleContainer styles to separate font-related properties from layout
  • Created new StyledPageInfoTextContainer wrapper to baseline-align title and label independently from the icon
  • Icon remains centered while text elements are baseline-aligned for better typography

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are purely visual styling adjustments that improve typography consistency. The refactoring properly separates layout concerns (baseline alignment wrapper) from styling concerns (font size), follows the codebase's styled-components patterns, and maintains backward compatibility with all existing usage
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/modules/command-menu/components/CommandMenuPageInfoLayout.tsx 5/5 Updated font size from sm to md for title and added baseline alignment wrapper for text elements

Sequence Diagram

sequenceDiagram
    participant Parent as Parent Component
    participant Layout as CommandMenuPageInfoLayout
    participant Icon as StyledPageInfoIcon
    participant TextContainer as StyledPageInfoTextContainer
    participant TitleDiv as StyledPageInfoTitleContainer
    participant Label as StyledPageInfoLabel

    Parent->>Layout: "Render with props"
    
    alt icon exists
        Layout->>Icon: "Render icon"
        Note over Icon: Centered alignment
    end
    
    Layout->>TextContainer: "Wrap text elements"
    Note over TextContainer: Baseline alignment applied
    
    TextContainer->>TitleDiv: "Render title"
    Note over TitleDiv: Font size md
    
    alt label exists
        TextContainer->>Label: "Render label"
        Note over Label: Font size sm
    end
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:21355

This environment will automatically shut down when the PR is closed or after 5 hours.

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Weiko Weiko merged commit e712eb0 into main Nov 28, 2025
68 of 70 checks passed
@Weiko Weiko deleted the fix-side-panel-header-title-style branch November 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants