Skip to content

fixed the horizontal padding on Navbar#16088

Merged
bosiraphael merged 1 commit intomainfrom
navbarHeaderPadding
Nov 28, 2025
Merged

fixed the horizontal padding on Navbar#16088
bosiraphael merged 1 commit intomainfrom
navbarHeaderPadding

Conversation

@Bonapara
Copy link
Copy Markdown
Member

Was 12px. Changed it to 8px to match Figma

CleanShot 2025-11-26 at 12 05 10

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Nov 26, 2025

Greptile Overview

Greptile Summary

Updated the command menu search bar horizontal padding from 12px to 8px to align with Figma design specifications. The change modifies the COMMAND_MENU_SEARCH_BAR_PADDING constant from 3 to 2 (which translates to 8px with the 4px spacing multiplicator).

Impact:

  • Affects CommandMenuTopBar component's left/right padding
  • Affects CommandMenuList component's max-height calculation

This is a minor visual adjustment with no functional or logical impact.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a straightforward design alignment change that only modifies a single padding constant. The constant is used in two components for spacing calculations, and the change has no impact on functionality or logic. The 4px reduction (from 12px to 8px) is a minor visual adjustment to match design specifications.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/modules/command-menu/constants/CommandMenuSearchBarPadding.ts 5/5 Changed horizontal padding constant from 3 to 2 (12px to 8px) to match Figma design specifications

Sequence Diagram

sequenceDiagram
    participant Constant as CommandMenuSearchBarPadding
    participant TopBar as CommandMenuTopBar
    participant List as CommandMenuList
    participant Theme as Theme System
    
    Note over Constant: COMMAND_MENU_SEARCH_BAR_PADDING = 2
    
    TopBar->>Constant: Import padding constant
    TopBar->>Theme: theme.spacing(2)
    Theme-->>TopBar: Returns "8px"
    Note over TopBar: Applies 8px horizontal padding<br/>to StyledInputContainer
    
    List->>Constant: Import padding constant
    List->>Theme: Calculate max-height using<br/>COMMAND_MENU_SEARCH_BAR_PADDING * 2
    Note over List: Uses padding in height calculation:<br/>PADDING * 2 = 16px total vertical space
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:24782

This environment will automatically shut down when the PR is closed or after 5 hours.

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry comment might need to be addressed otherwise LGTM

Copy link
Copy Markdown
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosiraphael bosiraphael merged commit 7bf68e5 into main Nov 28, 2025
72 checks passed
@bosiraphael bosiraphael deleted the navbarHeaderPadding branch November 28, 2025 14:12
NotYen pushed a commit to NotYen/twenty-ym that referenced this pull request Dec 4, 2025
Was 12px. Changed it to 8px to match Figma

<img width="550" height="301" alt="CleanShot 2025-11-26 at 12 05 10"
src="https://github.com/user-attachments/assets/edec07bd-74ee-4dd7-b433-20a5bb636e6b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants