fix menu-item floating buttons that should only be displayed on hover#1588
Merged
charlesBochet merged 1 commit intomainfrom Sep 15, 2023
Merged
fix menu-item floating buttons that should only be displayed on hover#1588charlesBochet merged 1 commit intomainfrom
charlesBochet merged 1 commit intomainfrom
Conversation
played on hover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuItems floating icons should only be displayed if the menu item is hovered:
and hovered:

We have two options to implement it:
I've used 2) so we can have it tested in the Storybook, I think it's important for a UI component to be properly tested and as we won't touch this component often, it's OK not going with the cleaner approach IMO