Merged
Conversation
Contributor
Author
LogDetails |
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR normalizes the .po file formatting across 30 translation files. The changes are purely cosmetic, standardizing multi-line msgid and msgstr entries by adding an empty string prefix before the continuation lines.
Key Changes:
- Multi-line translations now follow the standard gettext format:
msgstr ""followed by quoted continuation lines - Affects Swedish (sv-SE) day-of-week translations and delete account confirmation messages across multiple locales
- No actual translation content was modified - only formatting structure
Technical Context:
The .po (Portable Object) file format allows two equivalent representations for multi-line strings:
# Old format (still valid)
msgstr "Line 1\n"
"Line 2"
# New format (more standard)
msgstr ""
"Line 1\n"
"Line 2"
This standardization improves compatibility with i18n tooling and follows GNU gettext best practices.
Confidence Score: 5/5
- This PR is completely safe to merge with zero risk
- Score of 5 reflects that these are purely formatting changes to translation files with no functional impact. The changes normalize .po file format to follow gettext standards, which improves tooling compatibility. No translation content, logic, or functionality is affected.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-front/src/locales/sv-SE.po | 5/5 | Formatting normalization for multi-line translations - empty string prefix added to msgstr entries with newlines for proper .po format compliance |
| packages/twenty-front/src/locales/de-DE.po | 5/5 | Formatting normalization for multi-line msgid entry - standardizes .po file format |
| packages/twenty-front/src/locales/fr-FR.po | 5/5 | Formatting normalization for multi-line msgid and msgstr entries - standardizes .po file format |
| packages/twenty-front/src/locales/es-ES.po | 5/5 | Formatting normalization for multi-line msgid and msgstr entries - standardizes .po file format |
| packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po | 5/5 | Formatting normalization for multi-line translations - empty string prefix added for proper .po format |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Action
participant Tooling as i18n Extraction Tool
participant SourceCode as Source Code
participant POFiles as .po Translation Files
GHA->>Tooling: Trigger translation extraction
Tooling->>SourceCode: Extract translatable strings
SourceCode-->>Tooling: Return translation keys
Tooling->>POFiles: Update msgid entries
Tooling->>POFiles: Normalize multi-line format
Note over POFiles: Add empty string prefix<br/>for multi-line msgid/msgstr
POFiles-->>GHA: Updated translation files
GHA->>GHA: Create Pull Request
29 files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action