Skip to content

i18n - translations#15718

Merged
FelixMalfait merged 1 commit intomainfrom
i18n
Nov 8, 2025
Merged

i18n - translations#15718
FelixMalfait merged 1 commit intomainfrom
i18n

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Nov 8, 2025

Created by Github action

@FelixMalfait FelixMalfait merged commit 1362895 into main Nov 8, 2025
5 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch November 8, 2025 06:48
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Nov 8, 2025

Fails
🚫

node failed.

Log

Details
�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:6433:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6414:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5380:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
danger-results://tmp/danger-results-8da38912.json

Generated by 🚫 dangerJS against b5edba5

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR normalizes the .po file formatting across 30 translation files. The changes are purely cosmetic, standardizing multi-line msgid and msgstr entries by adding an empty string prefix before the continuation lines.

Key Changes:

  • Multi-line translations now follow the standard gettext format: msgstr "" followed by quoted continuation lines
  • Affects Swedish (sv-SE) day-of-week translations and delete account confirmation messages across multiple locales
  • No actual translation content was modified - only formatting structure

Technical Context:
The .po (Portable Object) file format allows two equivalent representations for multi-line strings:

# Old format (still valid)
msgstr "Line 1\n"
"Line 2"

# New format (more standard)
msgstr ""
"Line 1\n"
"Line 2"

This standardization improves compatibility with i18n tooling and follows GNU gettext best practices.

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • Score of 5 reflects that these are purely formatting changes to translation files with no functional impact. The changes normalize .po file format to follow gettext standards, which improves tooling compatibility. No translation content, logic, or functionality is affected.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/locales/sv-SE.po 5/5 Formatting normalization for multi-line translations - empty string prefix added to msgstr entries with newlines for proper .po format compliance
packages/twenty-front/src/locales/de-DE.po 5/5 Formatting normalization for multi-line msgid entry - standardizes .po file format
packages/twenty-front/src/locales/fr-FR.po 5/5 Formatting normalization for multi-line msgid and msgstr entries - standardizes .po file format
packages/twenty-front/src/locales/es-ES.po 5/5 Formatting normalization for multi-line msgid and msgstr entries - standardizes .po file format
packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po 5/5 Formatting normalization for multi-line translations - empty string prefix added for proper .po format

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Action
    participant Tooling as i18n Extraction Tool
    participant SourceCode as Source Code
    participant POFiles as .po Translation Files
    
    GHA->>Tooling: Trigger translation extraction
    Tooling->>SourceCode: Extract translatable strings
    SourceCode-->>Tooling: Return translation keys
    Tooling->>POFiles: Update msgid entries
    Tooling->>POFiles: Normalize multi-line format
    Note over POFiles: Add empty string prefix<br/>for multi-line msgid/msgstr
    POFiles-->>GHA: Updated translation files
    GHA->>GHA: Create Pull Request
Loading

29 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant