Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR is an automated i18n translation update that removes obsolete translation strings and adds new ones for enhanced permission controls.
Changes
- Removed translations: View-sort related error messages (5 strings removed across all locales)
- Added translations: New permission-related messages for workspace field updates and view management (4 new strings)
- Updated: Refactored permission error messages for workspace settings management
Translation Coverage
- English (en.po): Complete ✓
- All other locales: Missing translations for 4 new permission messages
The new untranslated strings are:
"The field \"{field}\" cannot be updated. Please contact your workspace administrator.""You do not have permission to update these fields: {fieldsList}. Please contact your workspace administrator.""You don't have permission to create workspace-level views.""You don't have permission to modify this view."
Impact
Generated TypeScript files include English fallback text for untranslated strings. Non-English users will see English error messages for these 4 new permission scenarios until translations are provided.
Confidence Score: 4/5
- Safe to merge - automated translation sync with incomplete non-English translations
- This is an automated translation update PR. The changes are straightforward (removing obsolete strings, adding new ones, compiling to TypeScript). However, 118 translations are missing across all non-English locales. While this won't break functionality (English fallbacks work), it affects UX for non-English users who will see English messages for new permission errors.
- All non-English
.pofiles need human translation for 4 new permission-related strings before the translation cycle is complete
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-server/src/engine/core-modules/i18n/locales/en.po | 5/5 | English source translations updated: removed obsolete view-sort messages, added new permission messages for workspace field updates and view permissions |
| packages/twenty-server/src/engine/core-modules/i18n/locales/fr-FR.po | 3/5 | French translations missing for 4 new permission-related messages added in this update |
| packages/twenty-server/src/engine/core-modules/i18n/locales/de-DE.po | 3/5 | German translations missing for 4 new permission-related messages |
| packages/twenty-server/src/engine/core-modules/i18n/locales/es-ES.po | 3/5 | Spanish translations missing for 4 new permission-related messages |
| packages/twenty-server/src/engine/core-modules/i18n/locales/generated/en.ts | 5/5 | Compiled English translations correctly generated from .po file |
| packages/twenty-server/src/engine/core-modules/i18n/locales/generated/fr-FR.ts | 5/5 | Compiled French translations generated, but includes untranslated English strings |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Code as Source Code
participant Extract as Lingui Extract
participant PO as .po Files
participant Compile as Lingui Compile
participant TS as Generated .ts Files
participant App as Application
Dev->>Code: Add/Update t() calls in code
Dev->>Extract: Run translation extraction
Extract->>Code: Scan source for t() calls
Extract->>PO: Update en.po with new msgid
Extract->>PO: Mark obsolete strings
Note over PO: All language .po files updated<br/>with empty msgstr for new strings
Dev->>Compile: Run translation compilation
Compile->>PO: Read all .po files
Compile->>TS: Generate TypeScript files
Note over TS: Missing translations use<br/>English fallback
App->>TS: Import translations at runtime
TS->>App: Return translated strings
Note over App: Non-English users see<br/>English for untranslated strings
No files reviewed, no comments
Contributor
Author
LogDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action