Merged
Conversation
martmull
approved these changes
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Added FieldMetadataType.RICH_TEXT_V2 to the SUPPORTED_FORM_FIELD_TYPES array in shouldDisplayFormField.ts. This enables rich text v2 fields to be displayed and editable in workflow action forms (CREATE_RECORD, UPDATE_RECORD, UPSERT_RECORD, and FIND_RECORDS actions).
- The change aligns with existing support for
RICH_TEXT_V2in other workflow components likeWorkflowStepFilterValueInputandWorkflowStepFilterFieldSelect FormFieldInputalready has proper handling forRICH_TEXT_V2viaFormRichTextV2FieldInputcomponent- This appears to restore functionality that may have been inadvertently omitted during previous workflow refactoring
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- Simple single-line addition that adds
RICH_TEXT_V2to an existing supported types array. The infrastructure to handle this field type already exists in the codebase (FormRichTextV2FieldInput, type guards, and similar support in other workflow components). No logic changes or edge cases introduced. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/utils/shouldDisplayFormField.ts | 5/5 | Added RICH_TEXT_V2 to supported form field types array to enable rich text fields in workflow actions |
Sequence Diagram
sequenceDiagram
participant User
participant WorkflowForm
participant shouldDisplayFormField
participant FormFieldInput
participant FormRichTextV2FieldInput
User->>WorkflowForm: Configure workflow action
WorkflowForm->>shouldDisplayFormField: Check if field should display
shouldDisplayFormField->>shouldDisplayFormField: Check if RICH_TEXT_V2 in SUPPORTED_FORM_FIELD_TYPES
alt RICH_TEXT_V2 is supported (after this PR)
shouldDisplayFormField-->>WorkflowForm: true
WorkflowForm->>FormFieldInput: Render field input
FormFieldInput->>FormRichTextV2FieldInput: Render rich text editor
FormRichTextV2FieldInput-->>User: Display rich text editor
else RICH_TEXT_V2 not supported (before this PR)
shouldDisplayFormField-->>WorkflowForm: false
WorkflowForm-->>User: Field hidden from form
end
1 file reviewed, no comments
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:37364 This environment will automatically shut down when the PR is closed or after 5 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rich text V2 is supported and has probably been removed by mistake
Fix #15660