Skip to content

Allow rich text v2 in workflows#15674

Merged
thomtrp merged 1 commit intomainfrom
tt-allow-rich-text-v2-in-workflows
Nov 6, 2025
Merged

Allow rich text v2 in workflows#15674
thomtrp merged 1 commit intomainfrom
tt-allow-rich-text-v2-in-workflows

Conversation

@thomtrp
Copy link
Copy Markdown
Contributor

@thomtrp thomtrp commented Nov 6, 2025

Rich text V2 is supported and has probably been removed by mistake

Fix #15660

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomtrp thomtrp enabled auto-merge (squash) November 6, 2025 14:27
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Added FieldMetadataType.RICH_TEXT_V2 to the SUPPORTED_FORM_FIELD_TYPES array in shouldDisplayFormField.ts. This enables rich text v2 fields to be displayed and editable in workflow action forms (CREATE_RECORD, UPDATE_RECORD, UPSERT_RECORD, and FIND_RECORDS actions).

  • The change aligns with existing support for RICH_TEXT_V2 in other workflow components like WorkflowStepFilterValueInput and WorkflowStepFilterFieldSelect
  • FormFieldInput already has proper handling for RICH_TEXT_V2 via FormRichTextV2FieldInput component
  • This appears to restore functionality that may have been inadvertently omitted during previous workflow refactoring

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple single-line addition that adds RICH_TEXT_V2 to an existing supported types array. The infrastructure to handle this field type already exists in the codebase (FormRichTextV2FieldInput, type guards, and similar support in other workflow components). No logic changes or edge cases introduced.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/utils/shouldDisplayFormField.ts 5/5 Added RICH_TEXT_V2 to supported form field types array to enable rich text fields in workflow actions

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowForm
    participant shouldDisplayFormField
    participant FormFieldInput
    participant FormRichTextV2FieldInput

    User->>WorkflowForm: Configure workflow action
    WorkflowForm->>shouldDisplayFormField: Check if field should display
    shouldDisplayFormField->>shouldDisplayFormField: Check if RICH_TEXT_V2 in SUPPORTED_FORM_FIELD_TYPES
    alt RICH_TEXT_V2 is supported (after this PR)
        shouldDisplayFormField-->>WorkflowForm: true
        WorkflowForm->>FormFieldInput: Render field input
        FormFieldInput->>FormRichTextV2FieldInput: Render rich text editor
        FormRichTextV2FieldInput-->>User: Display rich text editor
    else RICH_TEXT_V2 not supported (before this PR)
        shouldDisplayFormField-->>WorkflowForm: false
        WorkflowForm-->>User: Field hidden from form
    end
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@thomtrp thomtrp merged commit e4ae792 into main Nov 6, 2025
58 of 60 checks passed
@thomtrp thomtrp deleted the tt-allow-rich-text-v2-in-workflows branch November 6, 2025 14:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:37364

This environment will automatically shut down when the PR is closed or after 5 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Workflow] - let users edit the body of tasks via a workflow

3 participants