fix useTriggerProviderReconnect

[neo773]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes the useTriggerProviderReconnect hook by ensuring OAuth reconnection flows always redirect back to /settings/accounts after completion.

Key Changes:

• Modified the hook to always set redirectLocation to /settings/accounts via getSettingsPath(SettingsPath.Accounts) when calling triggerApisOAuth
• Updated all test expectations to validate that redirectLocation is consistently set, even when custom options are provided
• The change ensures a predictable user experience where reconnecting an account always returns users to the accounts settings page

Behavior:

• For OAuth providers (Google, Microsoft): Now always overrides any custom redirectLocation in options with /settings/accounts
• For IMAP_SMTP_CALDAV: Behavior unchanged - still navigates using the useNavigateSettings hook
• The spread operator ...options is placed before redirectLocation, ensuring the override always takes precedence

Confidence Score: 5/5

• This PR is safe to merge with no significant risks
• The changes are minimal, well-tested, and follow a clear intent to standardize redirect behavior. All tests have been updated to match the new behavior, demonstrating thorough coverage. The implementation correctly uses getSettingsPath utility and properly merges options while ensuring redirectLocation is always overridden.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
packages/twenty-front/src/modules/settings/accounts/hooks/useTriggerProviderReconnect.ts	4/5	Added automatic redirectLocation override to ensure OAuth reconnections always redirect to /settings/accounts page. The change forces a consistent redirect location regardless of provided options.
packages/twenty-front/src/modules/settings/accounts/hooks/tests/useTriggerProviderReconnect.test.tsx	5/5	Updated test expectations to validate that redirectLocation is always set to /settings/accounts, even when custom options are provided. Tests comprehensively cover the new override behavior.

Sequence Diagram

sequenceDiagram
    participant User
    participant Component
    participant Hook as useTriggerProviderReconnect
    participant OAuthHook as useTriggerApisOAuth
    participant Navigate
    participant Backend

    User->>Component: Clicks reconnect button
    Component->>Hook: triggerProviderReconnect(provider, accountId, options)
    
    alt IMAP provider
        alt no accountId provided
            Hook->>Navigate: Navigate to new connection
        else accountId provided
            Hook->>Navigate: Navigate to edit connection
        end
    else OAuth provider
        Note over Hook: Merge options with fixed redirectLocation
        Hook->>OAuthHook: triggerApisOAuth(provider, mergedOptions)
        OAuthHook->>Backend: Initiate provider flow
        Backend-->>User: Redirect after completion
    end

Loading

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:34849

This environment will automatically shut down when the PR is closed or after 5 hours.

[github-actions]

Thanks @neo773 for your contribution!
This marks your 53rd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter