Merged
Conversation
Contributor
Author
LogDetails |
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR adds a new translation string "Last credentials refreshed at" (translation ID: hHtzNQ) across all 31 supported locales in the i18n system. The string is used to describe a field in the connected account entity.
Changes Made
- Added new
msgidentry "Last credentials refreshed at" to all 31.posource files (af-ZA, ar-SA, ca-ES, cs-CZ, da-DK, de-DE, el-GR, en, es-ES, fi-FI, fr-FR, he-IL, hu-HU, it-IT, ja-JP, ko-KR, nl-NL, no-NO, pl-PL, pseudo-en, pt-BR, pt-PT, ro-RO, ru-RU, sr-Cyrl, sv-SE, tr-TR, uk-UA, vi-VN, zh-CN, zh-TW) - English locale (
en.po) has the translatedmsgstrset to the same value - All other locales have empty
msgstr ""entries, which is the standard workflow for newly extracted strings awaiting translation by translators - Regenerated all 31
.tscompiled translation catalogs with the new translation key included - Generated files are properly formatted as minified single-line TypeScript exports
Translation Workflow
This follows the standard i18n workflow:
- Developer adds translatable string in source code
- Extraction script runs to update all
.pofiles with newmsgid - Compilation script generates TypeScript files from
.posources - Application will use English fallback for untranslated locales until translators provide translations
Confidence Score: 5/5
- This PR is safe to merge with no risk - it's an automated i18n update that follows the standard translation workflow
- Score of 5 given because: (1) This is an automated translation extraction/compilation PR generated by GitHub Actions, (2) Changes follow the established i18n pattern used throughout the codebase, (3) Only adds a new translation key without modifying any logic, (4) All 62 files are consistent in their updates, (5) Generated TypeScript files are properly formatted and include the new key, (6) Empty translations for non-English locales are expected and standard practice
- No files require special attention - all changes are routine i18n updates
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-server/src/engine/core-modules/i18n/locales/en.po | 5/5 | Added new translation string "Last credentials refreshed at" (ID: hHtzNQ) for connected account field - source English text is correct |
| packages/twenty-server/src/engine/core-modules/i18n/locales/generated/en.ts | 5/5 | Generated TypeScript translation catalog updated with new translation key hHtzNQ - file is properly formatted as minified single-line JSON |
| packages/twenty-server/src/engine/core-modules/i18n/locales/fr-FR.po | 5/5 | Added new translation entry with empty msgstr (awaiting translation) - standard workflow for newly extracted strings |
| packages/twenty-server/src/engine/core-modules/i18n/locales/de-DE.po | 5/5 | Added new translation entry with empty msgstr (awaiting translation) - consistent with other locale files |
| packages/twenty-server/src/engine/core-modules/i18n/locales/generated/fr-FR.ts | 5/5 | Generated TypeScript catalog updated - properly compiled from source .po file with empty translations |
| packages/twenty-server/src/engine/core-modules/i18n/locales/es-ES.po | 5/5 | Added new translation entry with empty msgstr - awaiting Spanish translation |
| packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po | 5/5 | Added new translation entry with empty msgstr - awaiting Japanese translation |
| packages/twenty-server/src/engine/core-modules/i18n/locales/zh-CN.po | 5/5 | Added new translation entry with empty msgstr - awaiting Chinese translation |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Code as Source Code
participant Extract as Extract Script
participant PO as .po Files (31 locales)
participant Compile as Compile Script
participant TS as .ts Files (31 locales)
participant App as Application
Dev->>Code: Add new translatable string<br/>in connected-account entity
Code->>Extract: Trigger translation extraction
Extract->>Code: Scan source code for<br/>translation markers
Extract->>PO: Add msgid "Last credentials refreshed at"<br/>with empty msgstr to all 31 locales
Note over PO: English (en.po) has msgstr set,<br/>others have empty msgstr ""
PO->>Compile: Trigger compilation
Compile->>PO: Read .po files
Compile->>TS: Generate minified TypeScript<br/>with JSON.parse() for all locales
Note over TS: Single-line files with<br/>translation key hHtzNQ added
App->>TS: Import translation catalogs<br/>at runtime
TS->>App: Provide translations<br/>(fallback to English for untranslated)
No files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action