Add shortcut on dashboard workspace entity + add shortcuts#15603
Merged
bosiraphael merged 8 commits intomainfrom Nov 5, 2025
Merged
Add shortcut on dashboard workspace entity + add shortcuts#15603bosiraphael merged 8 commits intomainfrom
bosiraphael merged 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR adds keyboard shortcut support for navigating to the Dashboards page. On the backend, it adds shortcut: 'D' to the Dashboard workspace entity. On the frontend, it adds the GO_TO_DASHBOARDS navigation action with hotkey G+D, and registers Dashboard in the core object metadata enums.
Key changes:
- Backend: Added
shortcut: 'D'property toDashboardWorkspaceEntitydecorator - Frontend: Added
CoreObjectNamePlural.Dashboardenum value - Frontend: Added
GO_TO_DASHBOARDSnavigation action withG+Dhotkey - Frontend: Action includes proper permission checks and availability rules
Issue found:
- The new dashboard action has
position: 22, which duplicates the position of the companies action, causing a potential ordering conflict in the action menu
Confidence Score: 3/5
- Safe to merge after fixing the position conflict, as it's a simple addition with one logical error
- The implementation follows existing patterns correctly and adds proper permission checks. However, the duplicate position value (22) creates an ordering conflict with the companies action that must be resolved. All other changes are clean and follow the codebase conventions.
- packages/twenty-front/src/modules/action-menu/actions/record-actions/constants/DefaultRecordActionsConfig.tsx - fix duplicate position value and update subsequent positions
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-server/src/modules/dashboard/standard-objects/dashboard.workspace-entity.ts | 5/5 | added shortcut: 'D' property to dashboard entity decorator - simple, safe change |
| packages/twenty-front/src/modules/action-menu/actions/record-actions/constants/DefaultRecordActionsConfig.tsx | 2/5 | added dashboard navigation action with hotkey 'G+D', but has duplicate position value (22) that conflicts with companies action |
Sequence Diagram
sequenceDiagram
participant User
participant UI as Frontend UI
participant ActionMenu as Action Menu System
participant Metadata as Object Metadata
participant Backend as Backend API
Note over Backend: PR adds shortcut='D' to<br/>Dashboard entity
Backend->>Metadata: Sync metadata with shortcut
Note over UI: User presses G+D hotkey
User->>UI: Press G+D
UI->>ActionMenu: Trigger GO_TO_DASHBOARDS action
ActionMenu->>ActionMenu: Check shouldBeRegistered<br/>(permissions, current object)
ActionMenu->>Metadata: Get CoreObjectNamePlural.Dashboard
Metadata-->>ActionMenu: 'dashboards'
ActionMenu->>UI: Navigate to /objects/dashboards
UI-->>User: Display dashboards index page
4 files reviewed, 1 comment
...ront/src/modules/action-menu/actions/record-actions/constants/DefaultRecordActionsConfig.tsx
Outdated
Show resolved
Hide resolved
…tcuts-command-menu
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:50067 This environment will automatically shut down when the PR is closed or after 5 hours. |
bosiraphael
reviewed
Nov 4, 2025
...ront/src/modules/action-menu/actions/record-actions/constants/DefaultRecordActionsConfig.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @ehconitin for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

syncmetadata required!
closes https://discord.com/channels/1130383047699738754/1435260594176393256