Skip to content

feat: toggle board field visibilities#1547

Merged
lucasbordeau merged 1 commit intomainfrom
feat/change-opportunities-view-fields-visibility
Sep 13, 2023
Merged

feat: toggle board field visibilities#1547
lucasbordeau merged 1 commit intomainfrom
feat/change-opportunities-view-fields-visibility

Conversation

@thaisguigon
Copy link
Copy Markdown
Contributor

Closes #1537, Closes #1539

@thaisguigon thaisguigon marked this pull request as ready for review September 12, 2023 10:27
@ergomake
Copy link
Copy Markdown

ergomake bot commented Sep 12, 2023

Hi 👋

We couldn't create a preview environment for this pull-request 😥

You can see your environment build logs here. Please double-check your docker-compose.yml file is valid.

If you need help, email us at contact@getergomake.com or join Discord.

Click here to disable Ergomake.

@thaisguigon thaisguigon force-pushed the feat/change-opportunities-view-fields-visibility branch 2 times, most recently from 41d042d to 6d5c997 Compare September 12, 2023 14:18
Copy link
Copy Markdown
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

There are a lot of arrow functions, could we use regular functions instead to stay consistent with the codebase and what we already chose as a convention ?

@thaisguigon thaisguigon force-pushed the feat/change-opportunities-view-fields-visibility branch from 6d5c997 to baab25d Compare September 13, 2023 09:56
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

@lucasbordeau lucasbordeau merged commit 28e12d4 into main Sep 13, 2023
@lucasbordeau lucasbordeau deleted the feat/change-opportunities-view-fields-visibility branch September 13, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants