Skip to content

fix: Icon size stroke in MenuItem#1545

Merged
charlesBochet merged 5 commits intotwentyhq:mainfrom
AdityaPimpalkar:icon-stroke-fix
Sep 12, 2023
Merged

fix: Icon size stroke in MenuItem#1545
charlesBochet merged 5 commits intotwentyhq:mainfrom
AdityaPimpalkar:icon-stroke-fix

Conversation

@AdityaPimpalkar
Copy link
Copy Markdown
Contributor

fixes - #1511

@ergomake
Copy link
Copy Markdown

ergomake bot commented Sep 11, 2023

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1545.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1545.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1545.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@charlesBochet
Copy link
Copy Markdown
Member

Hi @AdityaPimpalkar, thanks for the help :)

I don't think that your PR is fixing the issue. The icon size is correct, the icon stroke is wrong.
To fix it:

  • add stroke={theme.icon.stroke.sm} on LeftIcon component.
  • you'll need to modify IconComponent to add stroke?: number; type

Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above!

Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@charlesBochet charlesBochet merged commit cdd7890 into twentyhq:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants