Conversation
martmull
approved these changes
Oct 21, 2025
Weiko
force-pushed
the
c--fix-serverless-update-not-saving-new-code-with-migration-v2
branch
from
37a97fb to
a6b5c59
Compare
Weiko
force-pushed
the
c--fix-serverless-update-not-saving-new-code-with-migration-v2
branch
from
a6b5c59 to
f3aaf28
Compare
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:6490 This environment will automatically shut down when the PR is closed or after 5 hours. |
Weiko
deleted the
c--fix-serverless-update-not-saving-new-code-with-migration-v2
branch
Weiko
commented
Oct 21, 2025
| super(ALL_METADATA_NAME.serverlessFunction); | ||
| } | ||
|
|
||
| public async validateAndBuild( |
Member
Author
There was a problem hiding this comment.
should have added "override" keyword to make it clearer, will do in the next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Regression introduced in #15032
With the new code, we don't have access to the from/to from the specialised builder anymore and we now rely on diffing result and cache to create the action which broke serverless update because "code" is not part of the cache nor part of the diffing (checksum is).
To maintain the existing architecture and keep it generic (by only modifying the specialized builder), the serverless builder overrides the parent validateAndBuild method