feat: persist view filters and sorts on Update View button click by thaisguigon · Pull Request #1290 · twentyhq/twenty

thaisguigon · 2023-08-22T15:12:00Z

Closes #1121
Closes #1123
Closes #1124
Closes #1289

ergomake · 2023-08-22T15:33:41Z

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1290.env.ergomake.link

Environment Summary 📑

Container	Source	URL
front	Dockerfile	https://front-twentyhq-twenty-1290.env.ergomake.link
server	Dockerfile	https://server-twentyhq-twenty-1290.env.ergomake.link
postgres	Dockerfile	[not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

emilienchvt

Nice one! A few quick comments on the naming of selectors and vocabulary diff between front and back.

When testing the feature I was surprised by a few behaviours:

When creating a new view, I’d expect it to be selected
After I create a filter on a new view, clicking on the “Filter button” toggles the filter&sorts bar which I find weird (Should enable new filter creation instead right ?)
No feedback when I “Update view” => I’d expect the button to be disabled Edit: addressed with #1293 (review)
When a view is selected, I can see a “cancel” button. I find it unclear what it does: it removes the filters and sorts of the view but does not change the “selected view” in the top bar.

emilienchvt · 2023-08-23T09:19:58Z

front/src/modules/ui/filter-n-sort/states/savedFiltersByKeyScopedState.ts

+
+import { savedFiltersScopedState } from './savedFiltersScopedState';
+
+export const savedFiltersByKeyScopedState = selectorFamily({


emilienchvt · 2023-08-23T09:20:38Z

front/src/modules/ui/filter-n-sort/states/savedFiltersByKeyScopedState.ts

+import { savedFiltersScopedState } from './savedFiltersScopedState';
+
+export const savedFiltersByKeyScopedState = selectorFamily({
+  key: 'savedFiltersByKeyScopedState',


Suggested change

key: 'savedFiltersByKeyScopedState',

key: 'savedFiltersByKeyScopedSelector',

Done, thank you! I renamed all the other sorts and filters selectors as well.

emilienchvt · 2023-08-23T09:21:13Z

front/src/modules/ui/filter-n-sort/states/savedSortsByKeyScopedState.ts

+import { savedSortsScopedState } from './savedSortsScopedState';
+
+export const savedSortsByKeyScopedState = selectorFamily({
+  key: 'savedSortsByKeyScopedState',


Suggested change

key: 'savedSortsByKeyScopedState',

key: 'savedSortsByKeyScopedSelector',

emilienchvt · 2023-08-23T09:22:00Z

front/src/modules/ui/filter-n-sort/states/sortsOrderByScopedState.ts

+import { sortsScopedState } from './sortsScopedState';
+
+export const sortsOrderByScopedState = selectorFamily({
+  key: 'sortsOrderByScopedState',


Suggested change

key: 'sortsOrderByScopedState',

key: 'sortsOrderByScopedSelector',

emilienchvt · 2023-08-23T09:33:26Z

front/src/modules/views/hooks/useViewFilters.ts

+          return availableFilter
+            ? ({
+                displayValue: viewFilter.displayValue ?? viewFilter.value,
+                field: viewFilter.key,


Should we have back and front agree on a naming key or field ?

Done, I renamed field to key in types Filter, FilterDefinition and FilterDefinitionByEntity. I chose to keep key because it is called key in the SortType type as well.

Closes #1121

Closes #1124, #1289

Closes #1123

- Rename recoil selectors - Rename filters `field` property to `key`

thaisguigon · 2023-08-23T15:14:34Z

Nice one! A few quick comments on the naming of selectors and vocabulary diff between front and back.

When testing the feature I was surprised by a few behaviours:

When creating a new view, I’d expect it to be selected

After I create a filter on a new view, clicking on the “Filter button” toggles the filter&sorts bar which I find weird (Should enable new filter creation instead right ?)

No feedback when I “Update view” => I’d expect the button to be disabled Edit: addressed with feat: disable Update View button if filters and sorts are up to date #1293 (review)

When a view is selected, I can see a “cancel” button. I find it unclear what it does: it removes the filters and sorts of the view but does not change the “selected view” in the top bar.

Good points!

I'll create an issue for this (switch to newly created view). Edit: On view creation, switch to new view #1297
As discussed with @charlesBochet: this will be addressed in an upcoming filters & sorts bar refactoring.
Already addressed in the PR you mentioned.
Not sure about this one, it might be addressed in the upcoming filters & sorts bar refactoring as well. Maybe labelling it differently ("Discard" for instance?) would make it clearer? @charlesBochet

charlesBochet · 2023-08-23T15:16:19Z

one, it might be addressed in the upcoming filters & sorts bar refactoring as well. Maybe labelling it differently ("Discard" for instance?) would make it clear

I think we should rediscuss this once we have cleared the behaviors regarding the sort and filter chips bar. What opens it, what closes it? Then we can discuss Cancel button role. I would consider it separate from this PR

charlesBochet

Great!

thaisguigon marked this pull request as ready for review August 22, 2023 15:12

emilienchvt reviewed Aug 23, 2023

View reviewed changes

thaisguigon added 5 commits August 23, 2023 15:54

feat: add viewFilters table

5c04b8e

Closes #1121

feat: add Update View button + Create View dropdown

f8c64b3

Closes #1124, #1289

feat: add View Filter resolvers

bf79f44

feat: persist view filters and sorts on Update View button click

97b2060

Closes #1123

refactor: code review

febc8c8

- Rename recoil selectors - Rename filters `field` property to `key`

thaisguigon force-pushed the feat/submit-view-filters-and-sorts branch from 5c63958 to febc8c8 Compare August 23, 2023 15:02

charlesBochet approved these changes Aug 23, 2023

View reviewed changes

charlesBochet merged commit 74ab014 into main Aug 23, 2023

charlesBochet deleted the feat/submit-view-filters-and-sorts branch August 23, 2023 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: persist view filters and sorts on Update View button click#1290

feat: persist view filters and sorts on Update View button click#1290
charlesBochet merged 5 commits intomainfrom
feat/submit-view-filters-and-sorts

thaisguigon commented Aug 22, 2023 •

edited

Loading

Uh oh!

ergomake bot commented Aug 22, 2023 •

edited

Loading

Uh oh!

emilienchvt left a comment •

edited

Loading

Uh oh!

emilienchvt Aug 23, 2023

Uh oh!

emilienchvt Aug 23, 2023

Uh oh!

thaisguigon Aug 23, 2023 •

edited

Loading

Uh oh!

emilienchvt Aug 23, 2023

Uh oh!

emilienchvt Aug 23, 2023

Uh oh!

emilienchvt Aug 23, 2023

Uh oh!

thaisguigon Aug 23, 2023

Uh oh!

thaisguigon commented Aug 23, 2023 •

edited

Loading

Uh oh!

charlesBochet commented Aug 23, 2023

Uh oh!

charlesBochet left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import { savedFiltersScopedState } from './savedFiltersScopedState';

		export const savedFiltersByKeyScopedState = selectorFamily({

	key: 'savedFiltersByKeyScopedState',
	key: 'savedFiltersByKeyScopedSelector',

	key: 'savedSortsByKeyScopedState',
	key: 'savedSortsByKeyScopedSelector',

	key: 'sortsOrderByScopedState',
	key: 'sortsOrderByScopedSelector',

Conversation

thaisguigon commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ergomake bot commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Environment Summary 📑

Uh oh!

emilienchvt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilienchvt Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

emilienchvt Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

thaisguigon Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilienchvt Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

emilienchvt Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

emilienchvt Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

thaisguigon Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

thaisguigon commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charlesBochet commented Aug 23, 2023

Uh oh!

charlesBochet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thaisguigon commented Aug 22, 2023 •

edited

Loading

ergomake bot commented Aug 22, 2023 •

edited

Loading

emilienchvt left a comment •

edited

Loading

thaisguigon Aug 23, 2023 •

edited

Loading

thaisguigon commented Aug 23, 2023 •

edited

Loading