Skip to content

Remove unused components#1180

Merged
charlesBochet merged 6 commits intomainfrom
remove-unused-components
Aug 12, 2023
Merged

Remove unused components#1180
charlesBochet merged 6 commits intomainfrom
remove-unused-components

Conversation

@charlesBochet
Copy link
Copy Markdown
Member

@charlesBochet charlesBochet commented Aug 12, 2023

In this PR:

  • remove dead code
  • fix a bug on Company and People tables. When a new row is added, the new row was not tracked by apollo properly. Especially, the onCompleted function of the fetch was not re-triggered on row update, making all edits on this row broken

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🧹

@ergomake
Copy link
Copy Markdown

ergomake bot commented Aug 12, 2023

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1180.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1180.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1180.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@charlesBochet charlesBochet merged commit 09ab130 into main Aug 12, 2023
@charlesBochet charlesBochet deleted the remove-unused-components branch August 12, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants