[PersonShow] use fieldDefinition for editable fields#1178
Merged
Conversation
Weiko
commented
Aug 11, 2023
| ) as FieldDefinition<FieldPhoneMetadata>; | ||
|
|
||
| // TODO: we could use a hook that would return the field value with the right type | ||
| const [fieldValue, setFieldValue] = useRecoilState<string>( |
Member
Author
There was a problem hiding this comment.
This component is very similar to textEditMode but we plan to add phone validation at some point
charlesBochet
approved these changes
Aug 11, 2023
|
Hi 👋 Here's a preview environment 🚀 https://front-twentyhq-twenty-1178.env.ergomake.link Environment Summary 📑
Here are your environment's logs. For questions or comments, join Discord. Click here to disable Ergomake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Same as #1171, we now want to use field definitions for the person show page.
Test
locally
Before
After
(I fixed the display in the company chip in a later commit, this should not display domain name here)