Skip to content

Use dedicated EditableFieldEntityIdContext for editable fields instead of CardIds#1145

Merged
Weiko merged 3 commits intomainfrom
c--use-entity-id-context-for-editable-fields
Aug 9, 2023
Merged

Use dedicated EditableFieldEntityIdContext for editable fields instead of CardIds#1145
Weiko merged 3 commits intomainfrom
c--use-entity-id-context-for-editable-fields

Conversation

@Weiko
Copy link
Copy Markdown
Member

@Weiko Weiko commented Aug 9, 2023

Context

After the recent refactoring done in #1089, we were using BoardId context to propagate the id later used for the different mutations applied on the editable fields.
We now want to use the same fields for show pages so it will make more sense to have something with a more generic name.

Test

@ergomake
Copy link
Copy Markdown

ergomake bot commented Aug 9, 2023

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1145.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1145.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1145.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@Weiko Weiko changed the title Use dedicated EntityIdContext for editable fields instead of CardIds Use dedicated EditableFieldEntityIdContext for editable fields instead of CardIds Aug 9, 2023
@Weiko Weiko merged commit cd831af into main Aug 9, 2023
@Weiko Weiko deleted the c--use-entity-id-context-for-editable-fields branch August 9, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants