Fix DataPoint & Ratio Calculations; Improve Output & Test Coverage

.gitignore

@@ -0,0 +1,2 @@
+.DS_Store
+.idea/y

client3.py

@@ -35,14 +35,14 @@ def getDataPoint(quote):
     stock = quote['stock']
     bid_price = float(quote['top_bid']['price'])
     ask_price = float(quote['top_ask']['price'])
-    price = bid_price
+    price = (bid_price + ask_price)/2
     return stock, bid_price, ask_price, price
 
 
 def getRatio(price_a, price_b):
-    """ Get ratio of price_a and price_b """
-    """ ------------- Update this function ------------- """
-    return 1
+    if price_b == 0:
+        raise ZeroDivisionError("Price B is zero, cannot compute ratio.")
+    return price_a / price_b
 
 
 # Main
@@ -52,8 +52,10 @@ def getRatio(price_a, price_b):
         quotes = json.loads(urllib.request.urlopen(QUERY.format(random.random())).read())
 
         """ ----------- Update to get the ratio --------------- """
+        prices = {}
         for quote in quotes:
             stock, bid_price, ask_price, price = getDataPoint(quote)
+            prices[stock] = price
             print("Quoted %s at (bid:%s, ask:%s, price:%s)" % (stock, bid_price, ask_price, price))
 
-        print("Ratio %s" % getRatio(price, price))
+        print("Ratio %s" % getRatio(prices["ABC"], prices["DEF"]))

client_test.py

@@ -1,25 +1,67 @@
 import unittest
-from client3 import getDataPoint
+from client3 import getDataPoint, getRatio
 
 class ClientTest(unittest.TestCase):
-  def test_getDataPoint_calculatePrice(self):
-    quotes = [
-      {'top_ask': {'price': 121.2, 'size': 36}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 120.48, 'size': 109}, 'id': '0.109974697771', 'stock': 'ABC'},
-      {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
-    ]
-    """ ------------ Add the assertion below ------------ """
 
-  def test_getDataPoint_calculatePriceBidGreaterThanAsk(self):
-    quotes = [
-      {'top_ask': {'price': 119.2, 'size': 36}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 120.48, 'size': 109}, 'id': '0.109974697771', 'stock': 'ABC'},
-      {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
-    ]
-    """ ------------ Add the assertion below ------------ """
+    def test_getDataPoint_calculatePrice(self):
+        quotes = [
+            {'top_ask': {'price': 121.2, 'size': 36}, 'timestamp': '2019-02-11 22:06:30.572453',
+             'top_bid': {'price': 120.48, 'size': 109}, 'id': '0.109974697771', 'stock': 'ABC'},
+            {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453',
+             'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
+        ]
 
+        # Calculate expected prices
+        expected_outputs = [
+            ('ABC', 120.48, 121.2, (120.48 + 121.2) / 2),  # (120.48 + 121.2) / 2 = 120.84
+            ('DEF', 117.87, 121.68, (117.87 + 121.68) / 2)  # (117.87 + 121.68) / 2 = 119.775
+        ]
 
-  """ ------------ Add more unit tests ------------ """
+        for quote, expected in zip(quotes, expected_outputs):
+            stock, bid_price, ask_price, price = getDataPoint(quote)
+            self.assertEqual(stock, expected[0])
+            self.assertEqual(bid_price, expected[1])
+            self.assertEqual(ask_price, expected[2])
+            self.assertAlmostEqual(price, expected[3], places=2)  # Match actual precision
 
+    def test_getDataPoint_calculatePriceBidGreaterThanAsk(self):
+        quotes = [
+            {'top_ask': {'price': 119.2, 'size': 36}, 'timestamp': '2019-02-11 22:06:30.572453',
+             'top_bid': {'price': 120.48, 'size': 109}, 'id': '0.109974697771', 'stock': 'ABC'},
+            {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453',
+             'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
+        ]
 
+        # Calculate expected prices
+        expected_outputs = [
+            ('ABC', 120.48, 119.2, (120.48 + 119.2) / 2),  # (120.48 + 119.2) / 2 = 119.84
+            ('DEF', 117.87, 121.68, (117.87 + 121.68) / 2)  # (117.87 + 121.68) / 2 = 119.775
+        ]
+
+        for quote, expected in zip(quotes, expected_outputs):
+            stock, bid_price, ask_price, price = getDataPoint(quote)
+            self.assertEqual(stock, expected[0])
+            self.assertEqual(bid_price, expected[1])
+            self.assertEqual(ask_price, expected[2])
+            self.assertAlmostEqual(price, expected[3], places=2)  # Match actual precision
+
+    def test_getRatio(self):
+        prices = {
+            'ABC': 120.84,
+            'DEF': 119.77
+        }
+        expected_ratio = prices['ABC'] / prices['DEF']
+
+        self.assertAlmostEqual(getRatio(prices['ABC'], prices['DEF']), expected_ratio, places=3)
+
+    def test_getRatio_zero_price(self):
+        prices = {
+            'ABC': 120.84,
+            'DEF': 0
+        }
+
+        with self.assertRaises(ZeroDivisionError):
+            getRatio(prices['ABC'], prices['DEF'])
 
 if __name__ == '__main__':
-    unittest.main()
+    unittest.main()