Skip to content

[addon-design-assets] Web View in Panel is not 100% Height #2

@mosherc

Description

@mosherc

Describe the bug
Design Assets panel does not show the full content of the web view.

To Reproduce
Steps to reproduce the behavior:

  1. Add addon design-assets
  2. Add a random web page to parameters.assets array in default export
  3. Go to story
  4. See web view in panel is cut off

Expected behavior
Web view inside panel takes up 100% of the height.

Screenshots
image

Code snippets

export default {
  title: 'Molecules/Modal',
  component: Modal,
  parameters: {
    assets: [
      'https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions', // link to a webpage
    ],
  },
} as Meta;

System
System:
OS: macOS 11.1
CPU: (8) x64 Apple M1
Binaries:
Node: 10.16.3 - ~/.nodenv/versions/10.16.3/bin/node
Yarn: 1.22.4 - ~/.nodenv/versions/10.16.3/bin/yarn
npm: 6.9.0 - ~/.nodenv/versions/10.16.3/bin/npm
Browsers:
Chrome: 88.0.4324.150
Firefox: 80.0
Safari: 14.0.2
npmPackages:
@storybook/addon-a11y: ^6.1.10 => 6.1.17
@storybook/addon-actions: ^6.1.16 => 6.1.17
@storybook/addon-design-assets: ^6.1.17 => 6.1.17
@storybook/addon-essentials: ^6.1.9 => 6.1.17
@storybook/addon-jest: ^6.1.17 => 6.1.17
@storybook/addon-storysource: ^6.1.9 => 6.1.17
@storybook/react: ^6.1.9 => 6.1.17
@storybook/source-loader: ^6.1.9 => 6.1.17
@storybook/theming: ^6.1.9 => 6.1.17

Additional context
Adding height: 100%; to this div fixes it:
image
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions