Conversation
Fixes 406 Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
bact
reviewed
Mar 31, 2026
| * @return an SPDX spec version 3 InvalidLicenseExpression | ||
| * @throws InvalidSPDXAnalysisException on any errors converting | ||
| */ | ||
| public InvalidLicenseExpression convertAndStore(org.spdx.library.model.v2.license.InvalidLicenseExpression fromInvalidExpression) throws InvalidSPDXAnalysisException { |
Collaborator
There was a problem hiding this comment.
Suggested change
| public InvalidLicenseExpression convertAndStore(org.spdx.library.model.v2.license.InvalidLicenseExpression fromInvalidExpression) throws InvalidSPDXAnalysisException { | |
| public InvalidLicenseExpression convertAndStore(org.spdx.library.model.v2.license.InvalidLicenseExpression fromInvalidLicenseExpression) throws InvalidSPDXAnalysisException { |
Since this is a public API, should we keep the full name here?
(I see an example from ExtractedLicenseInfo -> fromExtractedLicenseInfo at line 802)
| toObjectUri, "SimpleLicensing.InvalidLicenseExpression", copyManager, true, defaultUriPrefix); | ||
| toInvalidLicExpression.setCreationInfo(defaultCreationInfo); | ||
| toInvalidLicExpression.setMessage(fromInvalidExpression.getMessage()); | ||
| toInvalidLicExpression.setLicenseExpression(fromInvalidExpression.getMessage()); |
Collaborator
There was a problem hiding this comment.
Not sure about why we put the message from the SPDX v2 InvalidExpression.getMessage() to the SPDX v3 LicenseExpression.
Please ignore if this is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406