refactor!: use context instead of screenRefs#2476
Merged
maciekstosio merged 27 commits intomainfrom Nov 5, 2024
Merged
Conversation
…ciekstosio/refactor-custom-screen-transition
…ciekstosio/refactor-custom-screen-transition
…hub.com:software-mansion/react-native-screens into @maciekstosio/refactor-custom-screen-transition
satya164
reviewed
Nov 4, 2024
…maciekstosio/use-context-insteaf-of-screenRefs-for-CST
Base automatically changed from
@maciekstosio/refactor-custom-screen-transition
to
main
November 4, 2024 21:53
kkafar
approved these changes
Nov 5, 2024
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Minor remarks + our conversation
Comment on lines
+24
to
+25
| export function getShadowNodeWrapperAndTagFromRef(ref: View | null): { | ||
| shadowNodeWrapper: ShadowNodeWrapper; |
maciekstosio
deleted the
@maciekstosio/use-context-insteaf-of-screenRefs-for-CST
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces passing screenRefs into using context. This avoids unnecessary logic on react-navigation side.
Changes
Create Context that holds screen refs and add this ref in ScreenStackItem instead of doing same on react-navigation part. See the changes there: react-navigation/react-navigation#12225
Testing
See Example App > Swipe Back Animation (changes from react-navigation required: react-navigation/react-navigation#12225)
OR
react-navigation: TestScreenAnimation.tsx
native-stack v5: TestScreenAnimationV5.tsx
CST-NativeStackV5.mov
CST-ReactNavigation.mov
Checklist