refactor: move ScreenGestureDetector to ScreenStack#2449
Merged
maciekstosio merged 21 commits intomainfrom Nov 4, 2024
Merged
Conversation
…ciekstosio/refactor-custom-screen-transition
…ciekstosio/refactor-custom-screen-transition
Base automatically changed from
@maciekstosio/fix-customs-screen-transitions-
to
main
October 30, 2024 15:37
…hub.com:software-mansion/react-native-screens into @maciekstosio/refactor-custom-screen-transition
maciekstosio
requested review from
alduzy and
kkafar
and removed request for
kkafar
kkafar
reviewed
Nov 4, 2024
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
- Haven't tested the runtime, please ensure screen transitions work.
- The code changes look reasonable. I'm glad we stayed with wrapping only screen stack with single gesture detector (in opposition to wrapping every screen).
- Few questions & suggestions below.
- Great job overall!
Comment on lines
+65
to
+79
| const isGestureDetectorProviderNotDetected = | ||
| ScreenGestureDetector.name !== 'GHWrapper' && goBackGesture !== undefined; | ||
| const isGestureDetectorNotConfiguredProperly = | ||
| goBackGesture !== undefined && | ||
| screensRefs === undefined && | ||
| currentScreenId === undefined; | ||
|
|
||
| warnOnce( | ||
| isGestureDetectorProviderNotDetected, | ||
| 'Cannot detect GestureDetectorProvider in a screen that uses `goBackGesture`. Make sure your navigator is wrapped in GestureDetectorProvider.', | ||
| ); | ||
| warnOnce( | ||
| isGestureDetectorNotConfiguredProperly, | ||
| 'Custom Screen Transition require screensRefs and currentScreenId to be provided.', | ||
| ); |
Member
There was a problem hiding this comment.
Extract this to some helper function please
Comment on lines
+500
to
+504
| screensRefs?: GestureProviderProps['screensRefs']; | ||
| currentScreenId?: GestureProviderProps['currentScreenId']; | ||
| goBackGesture?: GestureProviderProps['goBackGesture']; | ||
| screenEdgeGesture?: GestureProviderProps['screenEdgeGesture']; | ||
| transitionAnimation?: GestureProviderProps['transitionAnimation']; |
Member
There was a problem hiding this comment.
Can we make something with these being repeated here? keyof ... operator?
Contributor
Author
There was a problem hiding this comment.
What about changing into interfaces? Changed in: 79571e2
Contributor
Author
I will test it again once everything merged. |
maciekstosio
deleted the
@maciekstosio/refactor-custom-screen-transition
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves logic required by Custom Screen Transition to react-native-screens from react-navigation (see react-navigation/react-navigation#11943). Instead of wrapping ScreenStack in NativeStack in react-navigation, we would add it to ScreenStack.
Testing
See Example App > Swipe Back Animation (changes from react-navigation required: react-navigation/react-navigation#12204)
Checklist