Support for react-native@0.73

[piaskowyk]

Summary

The PR adds support for react-native@0.73.

Related changes in react-native

Paper

* What went wrong:
A problem occurred configuring project ':react-native-reanimated'.
> defaultConfig contains custom BuildConfig fields, but the feature is disabled.
  To enable the feature, add the following to your module-level build.gradle:
  `android.buildFeatures.buildConfig true`

According to documentation, we can do it safely - https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BuildFeatures#buildConfig:kotlin.Boolean

• Deterministic onLayout event ordering for iOS Paper facebook/react-native#40748

Fabric

• https://github.com/facebook/react-native/pull/37588/files#diff-1aaade82ec15d197d2785561ee85f90029c7ebb46e75bc4a24967da1fc1cc041
• https://github.com/facebook/react-native/pull/36609/files#diff-e8a960fbc5a09cea2611fa92b7791c749c3fce1d02b614694d203d9712e97aa4
• https://github.com/facebook/react-native/pull/38276/files#diff-f53e9cf2e2c954166cb7a3cab84622f14af9eb3949dc1f29f76e4693a9e9cbde
• https://github.com/facebook/react-native/pull/36395/files#diff-2b25a23f0ed5ac2cf193ff05df77004c3eae39d5966e86a06d383f707d364cc8
• facebook/react-native@33ebb5d#diff-efac1ff476300ebbe947340c1864ad44dae2ae4f24ab7837395b337303db6313

Backward compatibility

[tomekzaw]

@efstathiosntonas Thanks for the reminder! Looks like this PR already contains these changes:

[tomekzaw]

[lafest]

@piaskowyk Hi, can you check this comment? #4913 (comment)

[piaskowyk]

Hey, could you tell me how I can reproduce this error?

[lafest]

@piaskowyk
I used xcode 14.3, react-native@0.73.0-rc.3, CLANG_CXX_LANGUAGE_STANDARD = "gnu++14" when I met the error. Is there any other information I can provide that will help solve this problem?

[mikehardy]

Would be nice to see this released, react-native 0.73 is on rc4 now and should go out soon
You all probably coordinate with releases like I do though, so you might be holding the release on purpose
Either way - was about to propose the exact same buildConfig true PR to build.gradle but saw this was already in :-)

Cheers

[daviddamilola]

Hello, thanks for you work. Pending the time this is released, what are the steps if i want to use react-native-reanimated from the main branch.

i tried to add it by doing this in package.json

"react-native-reanimated": "https://github.com/software-mansion/react-native-reanimated.git#main",

which works when building locally, but when doing a release build it breaks with this error

▸ Linking mobile

❌  ld: symbol(s) not found for architecture arm64

❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)

[altaywtf]

@daviddamilola I'm in a similar situation. 😅

you may give nightly builds a try:

• https://www.npmjs.com/package/react-native-reanimated?activeTab=versions
• https://www.npmjs.com/package/react-native-reanimated/v/3.6.0-nightly-20231114-0837247d4

worked for me with react-native-tvos@0.73.0-0rc1, Xcode 15.0.1 etc.

[daviddamilola]

Thanks @altaywtf , will try it out.

[UNIDY2002]

when doing a release build it breaks with this error

+1

Using the nightly does not seem to solve the problem.

See: https://github.com/thu-info-community/thu-info-app/actions/runs/6891922352/job/18748125712#step:11:2696

Not sure whether anything is wrong on my side.

[daviddamilola]

Thanks @altaywtf , will try it out.

Hello, i can confirm the error remains for v0.73.0-rc.4 but works for v0.73.0-rc.1

[UNIDY2002]

... when doing a release build it breaks with this error

▸ Linking mobile

❌  ld: symbol(s) not found for architecture arm64

❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)

It seems that this issue is fixed by bf7df79. I've tried on the latest nightly and the build error no longer shows up.

[mohan-sprinklr]

I met below error in RN0.73-rc.2. is there any change with handling hermes? if I comment out enableDebuggging and disableDebugging, build successfully completed.

Undefined symbols for architecture x86_64:
  "facebook::hermes::inspector_modern::chrome::enableDebugging(std::__1::unique_ptr<facebook::hermes::inspector_modern::RuntimeAdapter, std::__1::default_delete<facebook::hermes::inspector_modern::RuntimeAdapter>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)", referenced from:
      reanimated::ReanimatedHermesRuntime::ReanimatedHermesRuntime(std::__1::unique_ptr<facebook::hermes::HermesRuntime, std::__1::default_delete<facebook::hermes::HermesRuntime>>, std::__1::shared_ptr<facebook::react::MessageQueueThread> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in libRNReanimated.a(ReanimatedHermesRuntime.o)
  "facebook::hermes::inspector_modern::chrome::disableDebugging(int)", referenced from:
      reanimated::ReanimatedHermesRuntime::~ReanimatedHermesRuntime() in libRNReanimated.a(ReanimatedHermesRuntime.o)
ld: symbol(s) not found for architecture x86_64

Did you find the solution for this?
i am trying to upgrade react-native version from 0.72.6 to 0.73.6 and I have updated the version of react-native-reanimated to its latest version in which I am getting same issue.

[UNIDY2002]

@mohan-sprinklr IMHO, this should have been fixed in the latest release of react-native-reanimated. Would you mind confirm whether clearing build cache, re-running pod install and re-building the APP helps?

[mohan-sprinklr]

@mohan-sprinklr IMHO, this should have been fixed in the latest release of react-native-reanimated. Would you mind confirm whether clearing build cache, re-running pod install and re-building the APP helps?

I am still getting the issue in react-native-reanimated latest version i.e 3.8.0
For now I have added a quickfix to manually disable HERMES_DEBUGGER in node_moduels/react-native-reanimated/RNReanimated.podspec file

I cleared pod cache --> deleted Pods folder --> reinstalled pods --> cleared build folder inside xcode --> manually deleted xcode cache inside /Users//Library/Developer/Xcode
Nothing worked for me.

[ydvnishant001]

I think commenting the enableDebugging and disableDebugging option in "node_modules>react-native-reanimated>Common>cpp>ReanimatedRuntime>ReanimatedHermesRuntime.cpp" is better. SInce React Native has deprecated Remote JavaScript Debugging.

I can no longer see the option in Android dev-menu to remote debug. And the above methods are shown in dev-menu for ios earlier but now are deprecated but still being used by reanimated(I assume). So commenting them makes the build run successfully.

also @mohan-sprinklr , disabling hermes in debug did not fix the issue for me.

If anyone wants to use remote debugging they can follow this official guide - https://reactnative.dev/docs/next/other-debugging-methods. Which works on both ios and android.