Use the undeprecated fs.accessSync#7
Merged
sindresorhus merged 1 commit intosindresorhus:masterfrom Oct 17, 2016
SimenB:fs-access-sync
Merged
Use the undeprecated fs.accessSync#7sindresorhus merged 1 commit intosindresorhus:masterfrom SimenB:fs-access-sync
fs.accessSync#7sindresorhus merged 1 commit intosindresorhus:masterfrom
SimenB:fs-access-sync
Conversation
| return false; | ||
| } | ||
| }; | ||
| module.exports.sync = fs.existsSync; |
Owner
There was a problem hiding this comment.
I'm not interested in changing the behavior at this point. It would also make it inconsistent with the async version. Documentation change is enough.
Contributor
Author
There was a problem hiding this comment.
It's the exact same behavior though, except for dropping the overhead of try-catching? Unless I'm missing something?
Owner
There was a problem hiding this comment.
It's the exact same behavior though
They call different native methods internally.
except for dropping the overhead of try-catching?
Still try/catch: https://github.com/nodejs/node/blob/9bb250ba340a805b6189b9ad39716722e6c41618/lib/fs.js#L243-L251
Contributor
Author
|
@sindresorhus updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See nodejs/node#8364
Might even deprecate the whole module? Unsure how useful an asynchronous version is