Conversation
- bump docker/login-action v1 -> v2 - bump actions/checkout v2 -> v3 - docker build: target linux/amd64 platform - Dockerfile: silence curl
Collaborator
Author
|
I'm also getting the following warning when using the I've seen it before and I think it was from a dependency of a dependency, will try and remember. |
Owner
Yeah, I've noticed that one too, and I think you're right (dep of a dep) |
Collaborator
Author
|
Adding it here too - that warning is from plotly, see plotly/plotly.R#2125. |
Collaborator
Author
|
Just cleaned up/simplified a couple of the dicts, ready for review now. |
sigven
approved these changes
Jun 27, 2022
Owner
sigven
left a comment
There was a problem hiding this comment.
Looks good, Peter. Thanks a lot for doing these clean-ups.. :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding some small doc notes and cleaning the log messages a bit.
Also cleaned up/updated GitHub Action workflow.
See commit messages for details.