Querying via TCP broken

[clue]

This lib implements communication via UDP and TCP, however the TCP implementation is broken in several ways:

• Messages sent over TCP (both directions) are to be prefixed by the message length, as per RFC 1035 section 4.2.2, here
• Messages can be chunked and have to be reassembled based on the length prefix, here
• Uses blocking stream_socket_client() call to connect to the DNS server, here
• Uses Connection from the react/socket (server!) component, should use react/socket-client, here

Looks like some of these points are currently being addressed as part of #8.

[clue]

Sorry, forgot to mention: As per RFC 5966 this library prefers UDP over TCP. TCP is only used as a fallback if either the query or the answer message do not fit into a single UDP datagram (512 bytes max).

This means that this issue does not apply to most queries. However, this can easily be reproduced by using xip.io to query an arbitrary long domain name like:

$resolver->resolve('aaaaa.bbbb....zzzzz.xip.io');

[attozk]

@clue,

Sorry, forgot to mention: As per RFC 5966 this library prefers UDP over TCP. TCP is only used as a fallback if either the query or the answer message do not fit into a single UDP datagram (512 bytes max).

Doesn't this & that already take care of it?

[clue]

Doesn't this & that already take care of it?

I believe you mean this and this? If so, I think we might have a slight misunderstanding :)

RFC 5966 demands that DNS implementations MUST support both UDP and TCP transports.
This is in fact implemented in this library as you rightfully pointed out.

This library prefers UDP over TCP because it has less overhead and is therefor significantly faster.

However, due to some smaller issues listed in my initial post, the TCP implementation is completely broken and in fact completely without function.

Because this library prefers UDP over TCP, you might not notice this in normal operation. TCP is only used as a fallback if either the query or response message do not fit in a single 512 byte datagram. This can easily be reproduced as per my second post.

[attozk]

@clue okay I see what you are saying about UDP preference and TCP fallback.