Skip to content

Expose RFC6455 permessage-deflate#851

Closed
mbonneau wants to merge 1 commit intoratchetphp:0.4.xfrom
mbonneau:deflate
Closed

Expose RFC6455 permessage-deflate#851
mbonneau wants to merge 1 commit intoratchetphp:0.4.xfrom
mbonneau:deflate

Conversation

@mbonneau
Copy link
Copy Markdown
Member

Expose RFC6455 permessage-deflate.

@fascinated
Copy link
Copy Markdown

Running this in a test environment, working pretty smoothly so far!

@edhelas
Copy link
Copy Markdown

edhelas commented Jun 30, 2021

Bump @cboden @clue
I'm really waiting for that feature to land in Ratchet :)

@edhelas
Copy link
Copy Markdown

edhelas commented Apr 6, 2022

Bump. Still really interested to see it in Ratchet. It would really help for my project :)

@PaulRotmann
Copy link
Copy Markdown
Contributor

Hey! Thanks for this PR and for implementing WebSocket message deflate support! 🙏

We're giving Ratchet some much-needed love and attention! As part of our issue cleanup initiative (#1100), we've been reviewing PRs and their compatibility with our current direction..

While we definitely appreciate the effort and think message deflate support would be a valuable enhancement (as discussed in #382), we've identified a few concerns with this implementation. The changes appear to introduce breaking changes to the WsConnection constructor, which would require this to be part of a major version release. Additionally, the PR lacks test coverage to verify the functionality works as expected. Given our current focus on the 0.4 branch (see #850) as part of our major Ratchet revival initiative (#1054), new features like this would need to be reconsidered for future releases rather than the current 0.4 branch.

We're closing this PR for now, but as noted in #382, we'd still like to add this feature in a future release when we can properly handle the breaking changes it would require.

If you want to support Ratchet's revival, please consider sponsoring our work! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants