Skip to content

Arm backend: Make warning statement more clear#18582

Open
gggekov wants to merge 1 commit intopytorch:mainfrom
gggekov:fix_warning_FVP
Open

Arm backend: Make warning statement more clear#18582
gggekov wants to merge 1 commit intopytorch:mainfrom
gggekov:fix_warning_FVP

Conversation

@gggekov
Copy link
Copy Markdown
Collaborator

@gggekov gggekov commented Mar 30, 2026

Signed-off-by: George Gekov <george.gekov@arm.com>
Change-Id: I83fead0e62a0cf012b6754ba572efe4e2deb8b50
@gggekov gggekov requested a review from digantdesai as a code owner March 30, 2026 16:02
Copilot AI review requested due to automatic review settings March 30, 2026 16:02
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 30, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18582

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 3 Unrelated Failures

As of commit 921f4ea with merge base ae07d06 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 30, 2026
@gggekov gggekov added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Arm FVP runner script messaging to better describe performance/cycle-accuracy expectations when running Corstone FVP simulations.

Changes:

  • Updates the copyright year in run_fvp.sh.
  • Rewords the Corstone FVP performance/cycle-accuracy warning shown at runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# Copyright 2025 Arm Limited and/or its affiliates.
# Copyright 2026 Arm Limited and/or its affiliates.
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file previously carried a 2025 copyright header; changing it to only 2026 drops the original year. Other Arm scripts in this directory use a year range when spanning multiple years (e.g., 2025-2026). Consider using a 2025-2026 range here as well to preserve the original year and match the prevailing header pattern.

Suggested change
# Copyright 2026 Arm Limited and/or its affiliates.
# Copyright 2025-2026 Arm Limited and/or its affiliates.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God catch

echo "--------------------------------------------------------------------------------"
echo "Running ${elf_file} for ${target} run with FVP:${fvp_model} num_macs:${num_macs} timeout:${timeout}"
echo "WARNING: Corstone FVP is not cycle accurate and should NOT be used to determine valid runtime"
echo "The Corstone FVPs are cycle accurate for the NPU part, but note that the CPU performance is not cycle accurate."
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line no longer starts with a clear warning marker (e.g., "WARNING:") like other scripts (see run_vkml.sh). Keeping a consistent "WARNING:" prefix would make the performance caveat easier to spot in logs and align with existing messaging conventions.

Suggested change
echo "The Corstone FVPs are cycle accurate for the NPU part, but note that the CPU performance is not cycle accurate."
echo "WARNING: The Corstone FVPs are cycle accurate for the NPU part, but note that the CPU performance is not cycle accurate."

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year 2025-2026, sorry for missing this in internal review.

@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Mar 30, 2026

Known issue
FAILED backends/arm/test/ops/test_permute.py::test_permute_vgf_quant[rank_4_large

Ok to merge with this fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants