Fix UB in to_string(Error) for unrecognized error codes (#18554)#18554
Open
alexey-sidnev wants to merge 2 commits intopytorch:mainfrom
Open
Fix UB in to_string(Error) for unrecognized error codes (#18554)#18554alexey-sidnev wants to merge 2 commits intopytorch:mainfrom
alexey-sidnev wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18554
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit c70cfd1 with merge base 3d63ad8 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@alexey-sidnev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97662639. |
This PR needs a
|
meta-codesync
bot
changed the title
alexey-sidnev
pushed a commit
to alexey-sidnev/executorch
that referenced
this pull request
Mar 30, 2026
Summary: executorch::runtime::to_string(Error) returns const char* via a switch statement with no default case. For unrecognized error codes, the function falls off the end without returning (undefined behavior), which in practice returns nullptr. The fix: 1. Adds a fallback return "Error::Unknown" after the switch in to_string() (without a default: case, preserving -Wswitch coverage for missing enum values). 2. Adds tests for to_string() covering all 21 enum values and the unknown error code path. Differential Revision: D97662639
alexey-sidnev
force-pushed
the
export-D97662639
branch
from
fd5b53a to
baffc13
Compare
alexey-sidnev
pushed a commit
to alexey-sidnev/executorch
that referenced
this pull request
Mar 30, 2026
Summary: Pull Request resolved: pytorch#18554 executorch::runtime::to_string(Error) returns const char* via a switch statement with no default case. For unrecognized error codes, the function falls off the end without returning (undefined behavior), which in practice returns nullptr. The fix: 1. Adds a fallback return "Error::Unknown" after the switch in to_string() (without a default: case, preserving -Wswitch coverage for missing enum values). 2. Adds tests for to_string() covering all 21 enum values and the unknown error code path. Differential Revision: D97662639
alexey-sidnev
force-pushed
the
export-D97662639
branch
from
baffc13 to
eebaa51
Compare
alexey-sidnev
pushed a commit
to alexey-sidnev/executorch
that referenced
this pull request
Mar 30, 2026
Summary: executorch::runtime::to_string(Error) returns const char* via a switch statement with no default case. For unrecognized error codes, the function falls off the end without returning (undefined behavior), which in practice returns nullptr. The fix: 1. Adds a fallback return "Error::Unknown" after the switch in to_string() (without a default: case, preserving -Wswitch coverage for missing enum values). 2. Adds tests for to_string() covering all 21 enum values and the unknown error code path. Differential Revision: D97662639
alexey-sidnev
force-pushed
the
export-D97662639
branch
from
eebaa51 to
7d87728
Compare
Summary: Pull Request resolved: pytorch#18554 executorch::runtime::to_string(Error) returns const char* via a switch statement with no default case. For unrecognized error codes, the function falls off the end without returning (undefined behavior), which in practice returns nullptr. The fix: 1. Adds a fallback return "Error::Unknown" after the switch in to_string() (without a default: case, preserving -Wswitch coverage for missing enum values). 2. Adds tests for to_string() covering all 21 enum values and the unknown error code path. Differential Revision: D97662639
alexey-sidnev
force-pushed
the
export-D97662639
branch
from
7d87728 to
9c41977
Compare
Contributor
|
@alexey-sidnev has imported this pull request. If you are a Meta employee, you can view this in D97662639. |
JacobSzwejbka
approved these changes
Mar 30, 2026
Author
|
@pytorchbot merge |
|
Mergebot is not configured for this repository. Please use the merge button provided by GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
executorch::runtime::to_string(Error) returns const char* via a switch statement with no default case. For unrecognized error codes, the function falls off the end without returning (undefined behavior), which in practice returns nullptr.
The fix:
Differential Revision: D97662639