gh-93476: Fraction.limit_denominator speed increase#93477
Closed
mscuthbert wants to merge 7 commits intopython:mainfrom
Closed
gh-93476: Fraction.limit_denominator speed increase#93477mscuthbert wants to merge 7 commits intopython:mainfrom
mscuthbert wants to merge 7 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create only one new Fraction object during
limit_denominator()instead of the four previously made.Fixes #93476
I believe that each of the calls to
Fraction()can be called with_normalize=Falsebut I have not included that in this PR to limit the scope of changes to the minimum to verify no change in implementation.