Skip to content

gh-145917: Add MIME types for TTC and Haptics formats#145918

Open
clin1234 wants to merge 9 commits intopython:mainfrom
clin1234:patch-4
Open

gh-145917: Add MIME types for TTC and Haptics formats#145918
clin1234 wants to merge 9 commits intopython:mainfrom
clin1234:patch-4

Conversation

@clin1234
Copy link
Copy Markdown
Contributor

@clin1234 clin1234 commented Mar 13, 2026

Added new MIME types for font collections and haptics.
@clin1234 clin1234 requested a review from AA-Turner as a code owner March 13, 2026 14:27
@clin1234
Copy link
Copy Markdown
Contributor Author

clin1234 commented Apr 1, 2026

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.

* Add ``application/sql`` and ``application/vnd.sqlite3``.
(Contributed by Charlie Lin in :gh:`145698`.)
* Add ``image/jxl``. (Contributed by Foolbar in :gh:`144213`.)
* Add the following MIME types:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe combine the list in one because both lists were authored by you?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We then need to write „and gh …“

clin1234 and others added 4 commits April 1, 2026 19:28
Co-authored-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
Co-authored-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
Added new mimetypes for font and haptics.
@benediktjohannes
Copy link
Copy Markdown
Contributor

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.

No problem! Overall looks pretty good to me, nice contributions, thanks!

Copy link
Copy Markdown
Contributor

@benediktjohannes benediktjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking pretty good to me! I did not look up the correctness of the applications and the entrys in official databases, but I can‘t approve the changes either because of permissions, so from what I saw when having a look on it, this LGTM, thanks!

@benediktjohannes
Copy link
Copy Markdown
Contributor

Please also fix Bullet list ends without a blank line; unexpected unindent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants