Bug report
Bug description:
Following up on #128322, I noticed that the same pattern of setting LDFLAGS instead of LIBS is used frequently. Additionally, there is not consistency in the ordering of the added libraries, e.g., LIBS="$LIBS ..." vs LIBS="... $LIBS".
For cases where the linking order matters, I believe using LDFLAGS is incorrect and the existing $LIBS should always come first.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
Bug report
Bug description:
Following up on #128322, I noticed that the same pattern of setting
LDFLAGSinstead ofLIBSis used frequently. Additionally, there is not consistency in the ordering of the added libraries, e.g.,LIBS="$LIBS ..."vsLIBS="... $LIBS".For cases where the linking order matters, I believe using
LDFLAGSis incorrect and the existing$LIBSshould always come first.CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
LIBSconsistently overLDFLAGSin library build checks #128359