Improved pull request "Files Changed" experience feedback #163932
Replies: 2968 comments 1231 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this has been mentioned, but the "Awaiting Approval" button should have the option to leave a review when clicked instead of just showing the merge options (or lack thereof if merging is blocked). Especially, since comments are now scrollable in the review pop-up, this would be so useful! Now I have to click on "files changed" to see the review option, so the button is more noise than function at the top and further adds complexity for collaborators less familiar with the GitHub PR process. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
When viewing commits, the "< Prev" and "Next >" buttons now appear at the bottom of the commit message. |
Beta Was this translation helpful? Give feedback.
-
|
One thing which I think is missing is the highlighting of the selected text, at least within the same file/diff. For me, it would be particularly useful for quickly finding new method definitions within the same file. |
Beta Was this translation helpful? Give feedback.
-
|
I'm not sure whether this was already reported (how do I even search through 3k hidden comments?), but found two issues (that, at least for me, are regressions from previous implementation):
|
Beta Was this translation helpful? Give feedback.
-
|
When adding comments / marking files as viewed, if you go back to a different tab, like the "code" page, then come back to "Files Changed" you see the content as if you never made comments or marked a file is viewed. You have to refresh the page and then your marks come back |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Slash commands no longer work in the Submit Review dialog:
In the current, working, view:
|
Beta Was this translation helpful? Give feedback.
-
|
How about letting us hide file renames/moves like we can hide whitespace changes? https://github.com/orgs/community/discussions/159256 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Pending comments cannot be deleted or edited without clicking through to the commit that they're attached to. |
Beta Was this translation helpful? Give feedback.
-
|
Copilot blocks the code it's explaining, and can't be minimized. |
Beta Was this translation helpful? Give feedback.
-
|
Adding multiple suggested changes and comments on different lines as part of a review, I encountered a bug where when I went back to edit the previous suggested changes, sometimes the contents of the ```suggestion block would just be blank, sometimes altered with extra line breaks and spaces, etc. cancelling the edit and trying again one or more times would usually fix it. Another issue is the suggestion diff has suddenly stopped showing up in the preview tab, and persists across page reloads (even when I clear local storage, indexeddb, etc.) For clarity, this is all while the review was still in draft (unsubmitted) |
Beta Was this translation helpful? Give feedback.
-
|
I noticed that For example, if we look at this PR: ghostty-org/ghostty#11950
However, the
Note The |
Beta Was this translation helpful? Give feedback.
-
|
About the new experience Tip If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu. ✨ What's new Comment on any line: You can now comment on any line of a changed file, not just the lines surrounding a change. June 26: initial changelog Annotations on unchanged files Limited to 1,000 files in single file mode or 3,000 in experimental mode |
Beta Was this translation helpful? Give feedback.

























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions