defaults are set to dataframe as part of first step towards issue #1115#1390
Closed
SubhadityaMukherjee wants to merge 1 commit intoopenml:developfrom
Closed
defaults are set to dataframe as part of first step towards issue #1115#1390SubhadityaMukherjee wants to merge 1 commit intoopenml:developfrom
SubhadityaMukherjee wants to merge 1 commit intoopenml:developfrom
Conversation
Contributor
Author
|
Contrary to what the default github message says, this will not close the issue. This is step 1 out of 2 in removing the dict/array and only keeping dataframe. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1390 +/- ##
==========================================
Coverage ? 69.52%
==========================================
Files ? 38
Lines ? 5325
Branches ? 0
==========================================
Hits ? 3702
Misses ? 1623
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Oops.. looks like #1372 forgot to mention #1115. Looking at the work done so far, we should build on #1372 instead. I don't believe @eddiebergman is currently planning contributions to OpenML as he is moving to a new job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
First step towards issue #1115 as mentioned in the discussion.
What does this PR implement/fix? Explain your changes.
Here, only the defaults have been changed from either dict or array to dataframe.
How should this PR be tested?
Since only the defaults were changed. Might not need changes to tests. Although that remains to be seen.
Any other comments?
There are some issues with minio imports that might cause the test to fail. (Not part of changes done here)